patch expo-notifications to clear badge
#4475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4475.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpjruoicn0vc738j8bgg. |
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"dir","filePath":"node_modules/expo-notifications/android","reasons":["expoAutolinkingAndroid"],"hash":"34a8bdae7dbf9876ec48baa2fac0f75aaed01254"},{"type":"dir","filePath":"patches","reasons":["patchPackage"],"hash":"3b6ba76de1c638d3cad055eec08e6e8a46b3a874"}]Generated by PR labeler 🤖 |
gaearon
approved these changes
Jun 11, 2024
|
estrattonbailey
added a commit
that referenced
this pull request
Jun 11, 2024
* origin/main: (54 commits) patch `expo-notifications` to clear badge (#4475) Revert to old modal on android (#4458) Sort profile feedgens by likes (#4380) Revert "Fix undefined block (#4471)" (#4472) Fix undefined block (#4471) Open convo menu when tapping on chat with deleted account (#4470) stop using `addPushTokenListener` (#4467) add hitslop to repost button (#4469) Add a loading indicator to notifications when loading latest (#4468) Visually improve the empty state of feeds (#4466) Give a meaningful error in the composer when replying to a deleted post (#4464) Fix: show known feed error UI more reliably (#4463) Only validate persisted data for existing users (#4465) Check `canAskAgain` for notification permissions (#4460) Add support for new-tab clicks on feeds (#4462) Override legacy language codes for indonesian, hebrew, and yiddish (#4461) Ungate mobile web notification badge (#4459) Fix (#4430): Use separate hooks for shell mode animated styles (#4451) Throttle instead of debounce (#4456) debounce refetching listconvos (#4455) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The library that
expo-notificationsis using to clear the badge -ShortcutBadgerdoes not clear the badge count correctly for some reason. The documentation says that eitherclearCount(context, 0)orresetCount(context)should reset the badge, but it does not - even though the call returnstrue.Instead, we can use the Android API to clear the badge count.
Solution from flutter/flutter#25030 (comment), albeit in Java
Test Plan