Add native_pwi_disabled feature gate experiment
#4507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://social-app-pr-4507.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cpli4stds78s738buivg. |
|
gaearon
reviewed
Jun 15, 2024
| @@ -14,6 +14,8 @@ import {useNonReactiveCallback} from '../hooks/useNonReactiveCallback' | |||
| import {LogEvents} from './events' | |||
| import {Gate} from './gates' | |||
|
|
|||
| const SDK_KEY = 'client-SXJakO39w9vIhl3D44u8UupyzFl4oZ2qPIkjwcvuPsV' | |||
There was a problem hiding this comment.
mind using it below in the Provider? it's hardcoded there too
There was a problem hiding this comment.
Ah yes, good call
estrattonbailey
added a commit
that referenced
this pull request
Jun 18, 2024
* origin/main: (22 commits) Disable newskie dialog tap in hover card web (#4562) Implement thread locking (#4545) Prevent unecessary calls (#4561) Force callers of `getTimeAgo` to pass in the value for "now" (#4560) Fix: only apply self-thread load-more behavior on the outer edge of the reply tree (#4559) Server-side thread mutes (#4518) Explore fixes (#4540) Is it "newskie" or "newsky" 🤔 (#4557) fix keyboard overlaying onboarding inputs (#4558) Add `useGetTimeAgo` and utils (#4556) Unconditionally polyfill Intl.PluralRules for native (#4554) Dedupe Zod installation (#4551) Use exact imports for icons (#4549) Fix Android startup perf regression (#4544) Explore feed cards (#4521) Onboarding fixes (#4508) Add `native_pwi_disabled` feature gate experiment (#4507) Select, don't mutate (#4541) Don't show "Pin/Add" button on feed card w/ no session (#4539) Add patch for `RCTBaseTextInput` fixing `selectTextOnFocus` prop (#4533) ...
estrattonbailey
added a commit
that referenced
this pull request
Jun 18, 2024
* origin/main: (35 commits) Bump labeler limit to 20 (#4565) Migrate local thread mutes (#4523) Disable newskie dialog tap in hover card web (#4562) Implement thread locking (#4545) Prevent unecessary calls (#4561) Force callers of `getTimeAgo` to pass in the value for "now" (#4560) Fix: only apply self-thread load-more behavior on the outer edge of the reply tree (#4559) Server-side thread mutes (#4518) Explore fixes (#4540) Is it "newskie" or "newsky" 🤔 (#4557) fix keyboard overlaying onboarding inputs (#4558) Add `useGetTimeAgo` and utils (#4556) Unconditionally polyfill Intl.PluralRules for native (#4554) Dedupe Zod installation (#4551) Use exact imports for icons (#4549) Fix Android startup perf regression (#4544) Explore feed cards (#4521) Onboarding fixes (#4508) Add `native_pwi_disabled` feature gate experiment (#4507) Select, don't mutate (#4541) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an experiment to the logged-out view on native only. To do so, we need to fetch Statsig config immediately. So, if we have no user to resume from, we do a full load of Statsig data to ensure we have accurate config based on the stable device ID.
To do this, I tested calling
initializewithprefetchUserson the options object, but this failed all three tests I did, in that it didn't load the config in time. So I opted to adjust the API oftryFetchGatesto allowundefinedas the DID value, which will then fall back to using the stable device ID.This works in my testing every time:
yarn ios