Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explore feed cards #4521

Merged
merged 2 commits into from
Jun 17, 2024
Merged

Explore feed cards #4521

merged 2 commits into from
Jun 17, 2024

Conversation

estrattonbailey
Copy link
Member

@estrattonbailey estrattonbailey commented Jun 14, 2024

Essentially no change in design or functionality, just swaps in the new component.

CleanShot 2024-06-14 at 14 15 14@2x
CleanShot 2024-06-14 at 14 15 23@2x
CleanShot 2024-06-14 at 14 13 50@2x
CleanShot 2024-06-14 at 14 14 13@2x

Copy link

github-actions bot commented Jun 14, 2024

Old size New size Diff
7.42 MB 7.42 MB -43 B (-0.00%)

@estrattonbailey estrattonbailey changed the base branch from feed-source-card to main June 14, 2024 19:28
Copy link
Collaborator

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have not QA'd, code looks good

@estrattonbailey
Copy link
Member Author

Should be good 👍

@estrattonbailey estrattonbailey merged commit 077da08 into main Jun 17, 2024
6 checks passed
@gaearon gaearon deleted the explore-feed-cards branch June 17, 2024 20:03
estrattonbailey added a commit that referenced this pull request Jun 18, 2024
* origin/main: (22 commits)
  Disable newskie dialog tap in hover card web (#4562)
  Implement thread locking (#4545)
  Prevent unecessary calls (#4561)
  Force callers of `getTimeAgo` to pass in the value for "now" (#4560)
  Fix: only apply self-thread load-more behavior on the outer edge of the reply tree (#4559)
  Server-side thread mutes (#4518)
  Explore fixes (#4540)
  Is it "newskie" or "newsky" 🤔  (#4557)
  fix keyboard overlaying onboarding inputs (#4558)
  Add `useGetTimeAgo` and utils (#4556)
  Unconditionally polyfill Intl.PluralRules for native (#4554)
  Dedupe Zod installation (#4551)
  Use exact imports for icons (#4549)
  Fix Android startup perf regression (#4544)
  Explore feed cards (#4521)
  Onboarding fixes (#4508)
  Add `native_pwi_disabled` feature gate experiment (#4507)
  Select, don't mutate (#4541)
  Don't show "Pin/Add" button on feed card w/ no session (#4539)
  Add patch for `RCTBaseTextInput` fixing `selectTextOnFocus` prop (#4533)
  ...
estrattonbailey added a commit that referenced this pull request Jun 18, 2024
* origin/main: (35 commits)
  Bump labeler limit to 20 (#4565)
  Migrate local thread mutes (#4523)
  Disable newskie dialog tap in hover card web (#4562)
  Implement thread locking (#4545)
  Prevent unecessary calls (#4561)
  Force callers of `getTimeAgo` to pass in the value for "now" (#4560)
  Fix: only apply self-thread load-more behavior on the outer edge of the reply tree (#4559)
  Server-side thread mutes (#4518)
  Explore fixes (#4540)
  Is it "newskie" or "newsky" 🤔  (#4557)
  fix keyboard overlaying onboarding inputs (#4558)
  Add `useGetTimeAgo` and utils (#4556)
  Unconditionally polyfill Intl.PluralRules for native (#4554)
  Dedupe Zod installation (#4551)
  Use exact imports for icons (#4549)
  Fix Android startup perf regression (#4544)
  Explore feed cards (#4521)
  Onboarding fixes (#4508)
  Add `native_pwi_disabled` feature gate experiment (#4507)
  Select, don't mutate (#4541)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants