Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup flags #4891

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Cleanup flags #4891

merged 2 commits into from
Aug 8, 2024

Conversation

gaearon
Copy link
Collaborator

@gaearon gaearon commented Aug 8, 2024

These are launched:

  • suggested_follows_interstitial
  • small_avi_thumb

cc4dbd3 hardcodes them to true.

This is disabled:

  • request_notifications_permission_after_onboarding_v2

07261be hardcodes it to false.

Test Plan

Read the code closely.

Copy link

render bot commented Aug 8, 2024

@gaearon gaearon merged commit f1031d1 into main Aug 8, 2024
6 checks passed
@gaearon gaearon deleted the cleanup-flags branch August 8, 2024 14:25
Copy link

github-actions bot commented Aug 8, 2024

Old size New size Diff
7.16 MB 7.16 MB -258 B (-0.00%)

estrattonbailey added a commit that referenced this pull request Aug 8, 2024
* origin/main: (30 commits)
  Show just-posted replies above OP replies (#4901)
  Remove client filtering of starter packs (#4753)
  Remove show_avi_follow_button (#4900)
  Remove native_pwi_disabled (#4896)
  Fix overflow on posts (#4899)
  Move onPressReply into child component (#4898)
  Remove new_user_progress_guide (#4895)
  Remove explore_page_profile_card_social_proof (#4894)
  Remove ungroup_follow_backs gate (#4893)
  Remove unnecessary state update for reply gate (#4897)
  Include follow-based suggestions in interstitial (#4889)
  Cleanup flags (#4891)
  ALF suggested follows in profile header (#4828)
  Added trans (#4890)
  Keep interstitial fresh on refresh (#4888)
  Include popcluster in suggestion ranking (#4887)
  Add logging of selected feed preference when displaying the following feed (#4789)
  [Video] Visibility detection view (#4741)
  [Videos] Video player - PR #2 - better web support (#4732)
  [Video] Authed video upload (#4885)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants