Show just-posted replies above OP replies #4901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's confusing to have your post displace OP thread or other people's leaf posts.
|
Your Render PR Server URL is https://social-app-pr-4901.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cqqgeflumphs739veoeg. |
|
estrattonbailey
added a commit
that referenced
this pull request
Aug 8, 2024
* origin/main: (30 commits) Show just-posted replies above OP replies (#4901) Remove client filtering of starter packs (#4753) Remove show_avi_follow_button (#4900) Remove native_pwi_disabled (#4896) Fix overflow on posts (#4899) Move onPressReply into child component (#4898) Remove new_user_progress_guide (#4895) Remove explore_page_profile_card_social_proof (#4894) Remove ungroup_follow_backs gate (#4893) Remove unnecessary state update for reply gate (#4897) Include follow-based suggestions in interstitial (#4889) Cleanup flags (#4891) ALF suggested follows in profile header (#4828) Added trans (#4890) Keep interstitial fresh on refresh (#4888) Include popcluster in suggestion ranking (#4887) Add logging of selected feed preference when displaying the following feed (#4789) [Video] Visibility detection view (#4741) [Videos] Video player - PR #2 - better web support (#4732) [Video] Authed video upload (#4885) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4882.
Normally we show OP replies above all so that threads work. However, if you have just posted a reply, it is confusing to have it appear offscreen. Twitter handles this by prioritizing just-posted own replies above the OP's (but showing them below the OP's if you navigate away and back to the post). This accomplishes the same thing.
We can do this now because #4898 consolidated the logic for "after post" callback in the post thread component.
Test Plan
Normal mode:
1111.mov
Thread mode:
222.mov
Note that we only do this when we're sure we won't completely displace the OP post out of view:
333.mov
Concretely, this means that we only do this in threaded more or directly under the highlighted post. Otherwise, it feels too confusing to have the OP post disappear.