Improve styles #4916
Merged
Improve styles #4916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit fb118f3.
* Bottom border * Padding
haileyok
approved these changes
Aug 11, 2024
src/lib/styles.ts
Outdated
Comment on lines
68
to
69
| footerSpacer: {height: 50}, | ||
| contentContainer: {paddingBottom: 100}, |
There was a problem hiding this comment.
I'm going to revert these changes for now. I think we want to do this, but these are legacy styles and I'm kind of concerned about corner cases that might get missed if we change this (it broke the settings page on iOS for example to change this and would have needed some extra work)
src/view/com/pager/TabBar.tsx
Outdated
| @@ -167,7 +167,7 @@ const desktopStyles = StyleSheet.create({ | |||
| }, | |||
| item: { | |||
| paddingTop: 14, | |||
| paddingHorizontal: 14, | |||
| paddingHorizontal: 16, | |||
There was a problem hiding this comment.
i think lets keep this one at 14
haileyok
reviewed
Aug 11, 2024
Comment on lines
+185
to
+190
| <SearchInput | ||
| query={query} | ||
| onChangeQuery={onChangeText} | ||
| onPressCancelSearch={onPressCancelSearch} | ||
| onSubmitQuery={onSubmit} | ||
| /> |
There was a problem hiding this comment.
I swapped this out with with the SearchInput component.
estrattonbailey
added a commit
that referenced
this pull request
Aug 15, 2024
* origin/main: (28 commits) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) [Video] Invert usage of `setAudioActive` (#4924) Upgrade API, implement XRPC rework (#4857) rm from swift (#4923) Fix Android composer cursor bug by removing `setTimeout` from native composer `onChangeText` (#4922) Show handle in recent searches and fix truncation (#4917) Improve styles (#4916) Mark string for localization (#4920) Fix `occurred` typo (#4919) [Video] Resume background audio whenever muting video audio (#4915) [Videos] Add error boundary to native (#4914) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the style of the search input and icon on the right to look like the input on the another pages.
Displays the bottom border of TabBar, like on the Home page.
Match the button color style.
Update the broken border at the bottom of the settings page and adjust the margin.
Adjust the left drawer margin on mobile.