[Embed] Starter pack embed embed #4935
Conversation
|
Your Render PR Server URL is https://social-app-pr-4935.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cquf8brqf0us73aqecug. |
|
| {content.record.description && ( | ||
| <p className="text-sm mt-1">{content.record.description}</p> | ||
| )} | ||
| {!!content.joinedAllTimeCount && content.joinedAllTimeCount > 50 && ( |
There was a problem hiding this comment.
I wonder if we might want to always show this count for embeds. Or at least drop the count to something like 10 or 15?
There was a problem hiding this comment.
since you're also here @estrattonbailey, thoughts?
There was a problem hiding this comment.
I'm down to drop it to 10 or so. Should I do it for the in-app one too presumably?
There was a problem hiding this comment.
hmm, no strong opinions but i think leaving it alone in the app is fine. embeds feel more "immediately going to be seen" so think having the count show up there more easily is nice.
too bad we don't have like "joined in the last 24 hours" though.
There was a problem hiding this comment.
imo it should be consistent, whichever way we do it. bare in mind the most popular one in this UK wave (the quiet riot one) has only 67 joins
|
looks good, same question as eric re: the comment but i think you're right to comment it out. |
* origin/main: (28 commits) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) [Video] Invert usage of `setAudioActive` (#4924) Upgrade API, implement XRPC rework (#4857) rm from swift (#4923) Fix Android composer cursor bug by removing `setTimeout` from native composer `onChangeText` (#4922) Show handle in recent searches and fix truncation (#4917) Improve styles (#4916) Mark string for localization (#4920) Fix `occurred` typo (#4919) [Video] Resume background audio whenever muting video audio (#4915) [Videos] Add error boundary to native (#4914) ...
* origin/main: (50 commits) Add `list hidden` screen (#4958) Expose more methods, support disabled items (#4954) Expose more props from button (#4953) Fix orphaned feed slices, handle blocks (#4944) Tweak `expo-modules-core` hack patch (#4955) [Experiment] Always show bottom bar (#4946) Revert "[Video] Download videos" (#4945) Move global "Sign out" out of the current account row (#4941) Hack patch for testing OTA update crash behavior (#4942) [Video] Download videos (#4886) swap control files (#4936) [Embed] Starter pack embed embed (#4935) [Video] set audio category to ambient every time a new player is made (#4934) Add `/live/` to supported YouTube embed URLs (#4932) [Video] Try/catch video play/pause (#4930) Don't kick to login screen on network error (#4911) Remove .withProxy() calls (#4929) [Video] Audio duck off main thread (#4926) subclass agent to add setPersistSessionHandler (#4928) [Video] Fix crash when switching tabs (#4925) ...
Starter pack posts you can test with
https://bsky.app/profile/sturdyalex.bsky.social/post/3kzn2d2yrz42q
https://bsky.app/profile/sturdyalex.bsky.social/post/3kzn2e6hgli2s