-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Following settings to Lists #5313
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
lists-following - social-app PR #5313
September 13, 2024 01:54 — with
Render
Destroyed
gaearon
requested review from
pfrazee,
estrattonbailey,
mozzius and
haileyok
September 13, 2024 01:54
I wonder if a better behavior would be to show conversations when they're between people in the list. But we don't have a great way to do that right now anyway. |
|
estrattonbailey
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, good thought on ideal behavior too
estrattonbailey
added a commit
that referenced
this pull request
Sep 15, 2024
* origin/main: bump (#5348) Release 1.91.1 prep (#5339) [Video] Fix regression on audio session at launch (#5338) Don't open composer via hotkey if other dialog is already open (#5334) "N" keyboard shortcut to open a new post modal (#5197) [Video] Bump video (#5333) Apply Following settings to Lists (#5313) Always display next button on login page (#5326) [Video] Don't require email verification on self-host (#5332) [Video] Remember mute state while scrolling (#5331) Fix lexicon validation in PWI Discover (#5329) [Video] Remove `expo-video`, use `bluesky-video` (#5282)
Aeroxander
added a commit
to creaton-io/social-app
that referenced
this pull request
Sep 22, 2024
* remove scrollbar-gutter in fullscreen (bluesky-social#5258) * [Video] make hover state stick around if tapped (bluesky-social#5259) * increase target area of scrubber (bluesky-social#5265) * hls buffering tweaks (bluesky-social#5266) * disable autoplay within messages and trim feelers (bluesky-social#5260) * [Video] TEMP disable skip compression (bluesky-social#5271) * [Video] Cap duration (bluesky-social#5270) * fix min size for compression (bluesky-social#5272) * add (bluesky-social#5273) * [Video] Fix web autoplay (bluesky-social#5274) * make container relative (bluesky-social#5280) * remove double closing tag (bluesky-social#5257) * Add autoCapitalize to password field (bluesky-social#5216) * NUX API (bluesky-social#5278) * Set up nux API * Bump SDK * Naming * Imports * WIP * Progress on desktoip * WIP, avi not working on web * Disable avi * Add badges, clean up spacing * Copy * Don't open for logged out users * Hook up data * Rename * Refactor, integrate nux, snoozing * Fix some nux types * Dev helpers, string cleanup * Protect against 3p PDSs and bad responses * Protect against other exit methods, protect against multiple fetches * Copy * [Video] speculative .vtt file selection fix (bluesky-social#5296) * speculative vtt fix * add logging * Tabular numbers to video timestamp (bluesky-social#5293) * Fix notification scroll jump (bluesky-social#5297) * Renaming the Follow button to "Follow back" when followed by user (bluesky-social#5281) * Renaming the follow button to follow back when followed by user * Fixing conditions and reusing existing translation * Revert "Show some known OP replies in Following (bluesky-social#5049)" (bluesky-social#5301) This reverts commit bff6aed. * Add a hard-coded redirect for lulaoficial.bsky.social (bluesky-social#5303) * Add gate * Ensure dialog shows for all accounts without snoozing * Add retry * Handle overflow of bottom text * Handle display name * On android, change ten milly nux secondary action to save instead of share * Add ja and pt-BR translations * Suggested follows by actor (on profiles) updates (bluesky-social#5243) * If fallback, return nothing * Compress size a bit * Hide on own profile * Match load state * Remove gcTime * Filter out followed users * Feedback * Adjust image sizing (bluesky-social#5302) * Enable video_upload gate (bluesky-social#5311) * Fallback snoozing * Let display name wrap * Separate alt/crop, use new icon (bluesky-social#5321) * Fix notification->post jump for real (bluesky-social#5314) * Revert "Fix notification scroll jump (bluesky-social#5297)" This reverts commit e0d9e75. * Query notifications first * Image/video border + tweaks (bluesky-social#5324) * Image/video border (bluesky-social#5253) * Update AutoSizedImage.tsx * Update AutoSizedImage.tsx * Update Gallery.tsx * Update ExternalLinkEmbed.tsx * Update MediaPreview.tsx * Update UserAvatar.tsx * Update ExternalLinkEmbed.tsx * Update ExternalPlayerEmbed.tsx * Update ExternalGifEmbed.tsx * Update GifEmbed.tsx * Update ExternalGifEmbed.tsx * Update GifEmbed.tsx * Update UserAvatar.tsx * Update ExternalPlayerEmbed.tsx * Update ExternalPlayerEmbed.tsx * video * Update QuoteEmbed.tsx * Tweaks, abstract components --------- Co-authored-by: Minseo Lee <itoupluk427@gmail.com> * Add events * Disable pointer events on media border (bluesky-social#5327) * [Video] Remove `expo-video`, use `bluesky-video` (bluesky-social#5282) Co-authored-by: Samuel Newman <mozzius@protonmail.com> * Fix lexicon validation in PWI Discover (bluesky-social#5329) * [Video] Remember mute state while scrolling (bluesky-social#5331) * [Video] Don't require email verification on self-host (bluesky-social#5332) * Always display next button on login page (bluesky-social#5326) Co-authored-by: Vinícius Souza <39967235+vinifsouza@users.noreply.github.com> Co-authored-by: Hailey <me@haileyok.com> * Apply Following settings to Lists (bluesky-social#5313) * Apply Following settings to Lists * Remove dead code * [Video] Bump video (bluesky-social#5333) * "N" keyboard shortcut to open a new post modal (bluesky-social#5197) * feat: Add hook on web app to open composer with 'N' keyboard shortcut * Extract, don't fire open composer if already open * Ignore interactive elements --------- Co-authored-by: João Gabriel <joaog@nocorp.io> Co-authored-by: Hailey <me@haileyok.com> * Don't open composer via hotkey if other dialog is already open (bluesky-social#5334) * Don't open composer via hotkey if other dialog is already open * Check for lightbox also * Check for drawer * [Video] Fix regression on audio session at launch (bluesky-social#5338) * Release 1.91.1 prep (bluesky-social#5339) * Fixes to tests * intl extract * bump (bluesky-social#5348) * Add context to `Unmute` and `Mute` strings (bluesky-social#5340) Co-authored-by: Hailey <me@haileyok.com> * [UITextView] Add background color support to iOS selectable text (bluesky-social#5335) * Fix wrong empty state for liked by (bluesky-social#5343) * Nux after onboarding (bluesky-social#5357) * Don't show nux dialogs until post-onboarding * Don't show if over 10M * Disallow some font scaling * Remove overflow hidden from external link outer el (bluesky-social#5356) * Remove overflow hidden * Borders when no thumb * Fix overflow, add bg to no-thumb state * Cleanup * loosen checks on vtt file (bluesky-social#5359) * [Video] Fix scrubber tap target (bluesky-social#5360) * put padding on correct element * clear timeout on down * Update Portuguese localization (bluesky-social#5256) Co-authored-by: Henrique Marques <hfvmarques@gmail.com> Co-authored-by: Arthur Tavares <arthurabreu00@gmail.com> * Update French localization (bluesky-social#5227) Co-authored-by: Stanislas Signoud <signez@stanisoft.net> * Update Chinese localization (bluesky-social#5291) Co-authored-by: cirx <133132480+cirx1e@users.noreply.github.com> Co-authored-by: Kuwa Lee <kuwalee1069@gmail.com> * Update Korean localization (bluesky-social#5254) * Update Japanese translation (bluesky-social#5217) * Update catalan messages.po (bluesky-social#5223) Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> Co-authored-by: gsmt <samaritanojr006@gmail.com> * Updates to Irish translation, back to 100% (bluesky-social#5345) * [Video] Volume controls on web (bluesky-social#5363) * split up VideoWebControls * add basic slider * logarithmic volume * integrate mute state * fix typo * shared video volume * rm log * animate in/out * disable for touch devices * remove flicker on touch devices * more detailed comment * move into correct context provider * add minHeight * hack * bettern umber --------- Co-authored-by: Hailey <me@haileyok.com> * [Video] Fix safari showing spinner (bluesky-social#5364) * Milly tweaks (bluesky-social#5365) Co-authored-by: Hailey <me@haileyok.com> * [Video] Additional android fixes (bluesky-social#5373) * rm unused code * bump lib * invert bool * Bump 1.91.2 (bluesky-social#5387) * Tweak `pt-BR` string (bluesky-social#5372) * Pre-fill alt text with 10-million card post (bluesky-social#5389) * Pre-fill alt text with 10-million card post (bluesky-social#5377) * Clean up type * Tweak alt copy * Add pt translation, fix typo --------- Co-authored-by: Calvin <clavin@users.noreply.github.com> * Make like animation on web same speed as mobile (bluesky-social#5391) * Fix border radius on avatars (bluesky-social#5392) * Make it work with Xcode 16 (bluesky-social#5386) * Temporary Sentry hack patch for iOS 18 (bluesky-social#5400) * Revert unneeded changes to `expo-modules-core` patch (bluesky-social#5393) * remove expo-sentry (bluesky-social#5405) * Fix for undefined ref on hot reload on web (bluesky-social#5407) * Update sentry sourcemaps upload (bluesky-social#5409) * [Neue] Base (bluesky-social#5395) * Add fontScale, gate it, fix some computes * Add inter, integrate * Clean up * Apply to old Text component * Use numeric weight * Cleanup * Clean up appearance settings * Global tracking * Fix regular italic variant * Refactor settings and fontScale values * Remove flags * Get rid of lower weight font usage * Remove gate from settings * Refactor appearance settings for reuse * Add neue type nux * Update defaults * Load fonts, add fallback families * Load fonts via plugin in production * Fixes * Fix for web * Nits --------- Co-authored-by: Hailey <me@haileyok.com> * Fix font loading on web (bluesky-social#5412) * Copy font files during build * Fall back if error loading fonts * Fix ext embeds in DMs (bluesky-social#5419) * fix ext embeds in DMs * undo acciental rounding change * Revert provider stacking changes (bluesky-social#5423) * Remove expo/vector-icons from EditImage modal (bluesky-social#5422) * [Neue] Ligatures & composer (bluesky-social#5427) * Disable contextual ligatures * Ensure new type styles are applied to the composer * Clean up using real devices * Feedback * [Neue] Copy and spacing tweaks (bluesky-social#5428) * Copy and spacing tweaks * Copy tweaks * Adjust toggle components sizing (bluesky-social#5408) (cherry picked from commit a9cbd23) * [Neue] Parallel font loading on web (bluesky-social#5411) * Parallel font loading (cherry picked from commit 10e2b05) * Handle failures * Rely on font-face and preload tags for font loading (bluesky-social#5431) * Cache fonts for a year * Add eslint rule to fix imports without the `#/` path alias (bluesky-social#5175) * Add border to menu on web (bluesky-social#5439) * Language fixes (bluesky-social#5384) * Add some comments * Decouple language settings * Normalize on read/write * Refactor * Support device locale on app startup * Cleanup, port to web * Clean up comments * Comment * Try not to mutate * Protect util handling, update test * Dedupe array values * Add explicit non-handling of detached quotes in embed (bluesky-social#5156) * [Neue] Buttons (bluesky-social#5406) * Re-align button sizing (cherry picked from commit bcec243) * Use large, small, tiny (cherry picked from commit 1dc333c) * Tweaks * patch expo modules again (bluesky-social#5441) * Additional moderation (bluesky-social#5172) * Set up additional mod authorities * Filter out non-configurable mod authorities * WIP * Working * Cleanup, add mod * Cleanup * Add more debug logs * Tweak logs * Filter out imperative labels from typeaheads * Filter hideable content from notifications * Add api * Fall back in dev * Remove space * Use prod endpoint * Add tiny notice * Add notice to labeler card, show all labelers * Increase rounding for all embeds (bluesky-social#5421) * tweak image styles * fix reply image preview and covert to atoms * increase rounding on media inset border * decrease gap on desktop * fix inset styles * increase rounding on embeds to `md` * Couple edge cases --------- Co-authored-by: Eric Bailey <git@esb.lol> * Fixing hover card for labeler accounts (bluesky-social#5414) * Fixing hover card for labeler account * removing memo * Fixing extra spacing in notification text (bluesky-social#5396) * Validate TLD in signup (bluesky-social#5426) * add lib * add validation * log * add some common typos * add tests * reset hasWarned state on edit * shorten path * Move test file, adjust regex, add test * Get real nit picky --------- Co-authored-by: Eric Bailey <git@esb.lol> * Fix spacing (bluesky-social#5444) * [Neue] Font weights (bluesky-social#5442) * Align all font weights * Only load necessary fonts * Also comment out from hook --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> Co-authored-by: Hailey <me@haileyok.com> Co-authored-by: Gargaj <gargaj@conspiracy.hu> Co-authored-by: Eduardo Tachotte <58338880+0xEDU@users.noreply.github.com> Co-authored-by: Eric Bailey <git@esb.lol> Co-authored-by: Minseo Lee <itoupluk427@gmail.com> Co-authored-by: dan <dan.abramov@gmail.com> Co-authored-by: Wesley <46491851+wscld@users.noreply.github.com> Co-authored-by: Paul Frazee <pfrazee@gmail.com> Co-authored-by: Vinícius Souza <39967235+vinifsouza@users.noreply.github.com> Co-authored-by: João Gabriel <joaog@nocorp.io> Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> Co-authored-by: Henrique Marques <hfvmarques@gmail.com> Co-authored-by: Arthur Tavares <arthurabreu00@gmail.com> Co-authored-by: Stanislas Signoud <signez@stanisoft.net> Co-authored-by: Frudrax Cheng <i@cynosura.one> Co-authored-by: cirx <133132480+cirx1e@users.noreply.github.com> Co-authored-by: Kuwa Lee <kuwalee1069@gmail.com> Co-authored-by: Takayuki KUSANO <65759+tkusano@users.noreply.github.com> Co-authored-by: Ivan Beà <bea.ivan@gmail.com> Co-authored-by: gsmt <samaritanojr006@gmail.com> Co-authored-by: Kevin Scannell <kscanne@gmail.com> Co-authored-by: Calvin <clavin@users.noreply.github.com> Co-authored-by: Roscoe Rubin-Rottenberg <118622417+knotbin@users.noreply.github.com> Co-authored-by: futur <me@futuristick.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently Lists display every single reply from every user on the list. This makes them great for a narrow use case (watching every single reply from a small group of people) but difficult to use for a broad use case (keeping up with a scene).
This change applies the current Following feed settings and heuristics to Lists. This means you'll still see replies in Lists, but only when you have some context on that reply (i.e. you follow the parent, the grandparent, or the root). As a result, Lists where you follow a lot of people will appear chattier while Lists where you follow few people will mostly show top-level posts.
This also aligns Lists with the behavior of Posts tab in Starter Packs (which already worked this way).
Before
Every single reply was displayed, so whenever someone went on a reply spree, it drowned out other people on the list. Many faces appearing in the list weren't actually a part of the list.
before.mov
before2.mov
After
I don't follow almost anyone on this list so I mostly see top-level posts:
after2.mov
On this list, I follow some people so I'm starting to see more conversations within it:
after.mov