Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to Irish translation, back to 100% #5345

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Updates to Irish translation, back to 100% #5345

merged 2 commits into from
Sep 16, 2024

Conversation

kscanne
Copy link
Contributor

@kscanne kscanne commented Sep 14, 2024

No description provided.

surfdude29
surfdude29 reviewed Sep 14, 2024
View reviewed changes
src/locale/locales/ga/messages.po Outdated
Comment on lines 28 to 34
#: src/lib/hooks/useTimeAgo.ts:156
msgid "{0, plural, one {# day} other {# days}}"
msgstr ""

#: src/lib/hooks/useTimeAgo.ts:146
msgid "{0, plural, one {# hour} other {# hours}}"
msgstr ""
Copy link
Contributor

@surfdude29 surfdude29 Sep 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some existing strings seem to be being removed in this PR, like here? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks! Seems that I was working from an outdated POT file. If it's OK, I'll just add the missing translations on this branch and ask to be merged then? Sorry for the confusion.

Copy link
Contributor

@surfdude29 surfdude29 Sep 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries! Yeah there's a lot of churn in strings, they're being added and removed all the time, it's quite a job for us translators to keep up 😅

If it's OK, I'll just add the missing translations on this branch and ask to be merged then?

I should note that I'm by no means an expert on this stuff, but I'm wondering if that would work given the changes in the code references?

I don't know if this would be possible/easy, but would adding the new translations to the current messages.po file be an option? That was generated yesterday in preparation for Monday's 1.91.1 release:

https://github.com/bluesky-social/social-app/blob/main/src/locale/locales/ga/messages.po

Btw, in case it's helpful, you can check how complete the translation will be for any language if a specific PR is merged:

  • Look in the All checks have passed section at the bottom of any PR
  • Click on the Details link for the Lint / Run linters (pull_request) entry
  • Click the Check & compile i18n line

You'll then see a table which shows what the total number of translated strings for each language and the number of missing translations will be when the message catalogs are compiled as a result of the PR.

For this PR, for instance, this is the current link, and clicking the Check & compile i18n line will show you this table:

IMG_1982

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this will be a huge help going forward, thanks. And to be clearer than my post above, I'm actually resyncing my translation with the latest messages.po and not just adding the missing strings — the next commit (hopefully tonight) should have the correct references and so on.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent 👌

Glad I could help :)

@kscanne kscanne requested a review from surfdude29 September 15, 2024 16:37
surfdude29
surfdude29 reviewed Sep 15, 2024
View reviewed changes
Copy link
Contributor

@surfdude29 surfdude29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lingui's showing 0 missing strings now, looks great to me, nice work! 🚀

Now we just have to wait for when @pfrazee does the next translation merges :)

haileyok
haileyok reviewed Sep 16, 2024
View reviewed changes
src/locale/locales/ga/messages.po
#: src/lib/moderation/useGlobalLabelStrings.ts:34
#: src/lib/moderation/useModerationCauseDescription.ts:144
#: src/view/com/modals/SelfLabel.tsx:76
#: src/lib/moderation/useGlobalLabelStrings.ts:34 src/lib/moderation/useModerationCauseDescription.ts:144 src/view/com/modals/SelfLabel.tsx:76
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@surfdude29 You might know better since you look at these a lot. Shouldn't the different file paths be on separate lines here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@haileyok They are on separate lines when they're generated by Lingui, but Lingui seems to deal with them being on the same line OK too (which some software like POEdit does).

Also, if you look at the linter results as described in this comment, Lingui seems to compile the message catalogs perfectly fine as it shows 0 missing translations.

So I'm pretty sure it's A-OK 👌

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, thanks for the explanation!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :)

haileyok
haileyok approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks everyone!

@haileyok haileyok merged commit 38c8f01 into bluesky-social:main Sep 16, 2024
6 checks passed
haileyok pushed a commit that referenced this pull request Sep 16, 2024
@kscanne @haileyok
Updates to Irish translation, back to 100% (#5345)
253bca8 
(cherry picked from commit 38c8f01)
estrattonbailey added a commit that referenced this pull request Sep 16, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into milly-tweaks
a929a6b 
* origin/main:
  [Video] Fix safari showing spinner (#5364)
  [Video] Volume controls on web (#5363)
  Updates to Irish translation, back to 100% (#5345)
  Update catalan messages.po (#5223)
  Update Japanese translation (#5217)
  Update Korean localization (#5254)
  Update Chinese localization (#5291)
  Update French localization (#5227)
  Update Portuguese localization (#5256)
estrattonbailey added a commit that referenced this pull request Sep 17, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into mod-auth
b4e544f 
* origin/main: (113 commits)
  Bump 1.91.2 (#5387)
  [Video] Additional android fixes (#5373)
  Milly tweaks (#5365)
  [Video] Fix safari showing spinner (#5364)
  [Video] Volume controls on web (#5363)
  Updates to Irish translation, back to 100% (#5345)
  Update catalan messages.po (#5223)
  Update Japanese translation (#5217)
  Update Korean localization (#5254)
  Update Chinese localization (#5291)
  Update French localization (#5227)
  Update Portuguese localization (#5256)
  [Video] Fix scrubber tap target (#5360)
  loosen checks on vtt file (#5359)
  Remove overflow hidden from external link outer el (#5356)
  Disallow some font scaling
  Nux after onboarding (#5357)
  Fix wrong empty state for liked by (#5343)
  [UITextView] Add background color support to iOS selectable text (#5335)
  Add context to `Unmute` and `Mute` strings (#5340)
  ...
estrattonbailey added a commit that referenced this pull request Sep 17, 2024
@estrattonbailey
Merge remote-tracking branch 'origin/main' into font-scaling
82dc47a 
* origin/main: (24 commits)
  Fix border radius on avatars (#5392)
  Make like animation on web same speed as mobile (#5391)
  Pre-fill alt text with 10-million card post (#5389)
  Tweak `pt-BR` string (#5372)
  Bump 1.91.2 (#5387)
  [Video] Additional android fixes (#5373)
  Milly tweaks (#5365)
  [Video] Fix safari showing spinner (#5364)
  [Video] Volume controls on web (#5363)
  Updates to Irish translation, back to 100% (#5345)
  Update catalan messages.po (#5223)
  Update Japanese translation (#5217)
  Update Korean localization (#5254)
  Update Chinese localization (#5291)
  Update French localization (#5227)
  Update Portuguese localization (#5256)
  [Video] Fix scrubber tap target (#5360)
  loosen checks on vtt file (#5359)
  Remove overflow hidden from external link outer el (#5356)
  Disallow some font scaling
  ...
Aeroxander added a commit to creaton-io/social-app that referenced this pull request Sep 22, 2024
@Aeroxander @mozzius
@haileyok @Gargaj @0xEDU @estrattonbailey @quiple @gaearon @wscld @pfrazee @vinifsouza @joao3g @surfdude29 @hfvmarques @arthurtavaresdev @Signez @auroursa @cirx1e @KuwaLee @tkusano @ivanbea @rortan134 @kscanne @clavin @knotbin @futurGH
Sync pr (#2)
59c01a6 
* remove scrollbar-gutter in fullscreen (bluesky-social#5258)

* [Video] make hover state stick around if tapped (bluesky-social#5259)

* increase target area of scrubber (bluesky-social#5265)

* hls buffering tweaks (bluesky-social#5266)

* disable autoplay within messages and trim feelers (bluesky-social#5260)

* [Video] TEMP disable skip compression (bluesky-social#5271)

* [Video] Cap duration (bluesky-social#5270)

* fix min size for compression (bluesky-social#5272)

* add (bluesky-social#5273)

* [Video] Fix web autoplay (bluesky-social#5274)

* make container relative (bluesky-social#5280)

* remove double closing tag (bluesky-social#5257)

* Add autoCapitalize to password field (bluesky-social#5216)

* NUX API (bluesky-social#5278)

* Set up nux API

* Bump SDK

* Naming

* Imports

* WIP

* Progress on desktoip

* WIP, avi not working on web

* Disable avi

* Add badges, clean up spacing

* Copy

* Don't open for logged out users

* Hook up data

* Rename

* Refactor, integrate nux, snoozing

* Fix some nux types

* Dev helpers, string cleanup

* Protect against 3p PDSs and bad responses

* Protect against other exit methods, protect against multiple fetches

* Copy

* [Video] speculative .vtt file selection fix (bluesky-social#5296)

* speculative vtt fix

* add logging

* Tabular numbers to video timestamp (bluesky-social#5293)

* Fix notification scroll jump (bluesky-social#5297)

* Renaming the Follow button to "Follow back" when followed by user (bluesky-social#5281)

* Renaming the follow button to follow back when followed by user

* Fixing conditions and reusing existing translation

* Revert "Show some known OP replies in Following (bluesky-social#5049)" (bluesky-social#5301)

This reverts commit bff6aed.

* Add a hard-coded redirect for lulaoficial.bsky.social (bluesky-social#5303)

* Add gate

* Ensure dialog shows for all accounts without snoozing

* Add retry

* Handle overflow of bottom text

* Handle display name

* On android, change ten milly nux secondary action to save instead of share

* Add ja and pt-BR translations

* Suggested follows by actor (on profiles) updates (bluesky-social#5243)

* If fallback, return nothing

* Compress size a bit

* Hide on own profile

* Match load state

* Remove gcTime

* Filter out followed users

* Feedback

* Adjust image sizing (bluesky-social#5302)

* Enable video_upload gate (bluesky-social#5311)

* Fallback snoozing

* Let display name wrap

* Separate alt/crop, use new icon (bluesky-social#5321)

* Fix notification->post jump for real (bluesky-social#5314)

* Revert "Fix notification scroll jump (bluesky-social#5297)"

This reverts commit e0d9e75.

* Query notifications first

* Image/video border + tweaks (bluesky-social#5324)

* Image/video border (bluesky-social#5253)

* Update AutoSizedImage.tsx

* Update AutoSizedImage.tsx

* Update Gallery.tsx

* Update ExternalLinkEmbed.tsx

* Update MediaPreview.tsx

* Update UserAvatar.tsx

* Update ExternalLinkEmbed.tsx

* Update ExternalPlayerEmbed.tsx

* Update ExternalGifEmbed.tsx

* Update GifEmbed.tsx

* Update ExternalGifEmbed.tsx

* Update GifEmbed.tsx

* Update UserAvatar.tsx

* Update ExternalPlayerEmbed.tsx

* Update ExternalPlayerEmbed.tsx

* video

* Update QuoteEmbed.tsx

* Tweaks, abstract components

---------

Co-authored-by: Minseo Lee <itoupluk427@gmail.com>

* Add events

* Disable pointer events on media border (bluesky-social#5327)

* [Video] Remove `expo-video`, use `bluesky-video` (bluesky-social#5282)

Co-authored-by: Samuel Newman <mozzius@protonmail.com>

* Fix lexicon validation in PWI Discover (bluesky-social#5329)

* [Video] Remember mute state while scrolling (bluesky-social#5331)

* [Video] Don't require email verification on self-host (bluesky-social#5332)

* Always display next button on login page (bluesky-social#5326)

Co-authored-by: Vinícius Souza <39967235+vinifsouza@users.noreply.github.com>
Co-authored-by: Hailey <me@haileyok.com>

* Apply Following settings to Lists (bluesky-social#5313)

* Apply Following settings to Lists

* Remove dead code

* [Video] Bump video (bluesky-social#5333)

* "N" keyboard shortcut to open a new post modal (bluesky-social#5197)

* feat: Add hook on web app to open composer with 'N' keyboard shortcut

* Extract, don't fire open composer if already open

* Ignore interactive elements

---------

Co-authored-by: João Gabriel <joaog@nocorp.io>
Co-authored-by: Hailey <me@haileyok.com>

* Don't open composer via hotkey if other dialog is already open (bluesky-social#5334)

* Don't open composer via hotkey if other dialog is already open

* Check for lightbox also

* Check for drawer

* [Video] Fix regression on audio session at launch (bluesky-social#5338)

* Release 1.91.1 prep (bluesky-social#5339)

* Fixes to tests

* intl extract

* bump (bluesky-social#5348)

* Add context to `Unmute` and `Mute` strings (bluesky-social#5340)

Co-authored-by: Hailey <me@haileyok.com>

* [UITextView] Add background color support to iOS selectable text (bluesky-social#5335)

* Fix wrong empty state for liked by (bluesky-social#5343)

* Nux after onboarding (bluesky-social#5357)

* Don't show nux dialogs until post-onboarding

* Don't show if over 10M

* Disallow some font scaling

* Remove overflow hidden from external link outer el (bluesky-social#5356)

* Remove overflow hidden

* Borders when no thumb

* Fix overflow, add bg to no-thumb state

* Cleanup

* loosen checks on vtt file (bluesky-social#5359)

* [Video] Fix scrubber tap target (bluesky-social#5360)

* put padding on correct element

* clear timeout on down

* Update Portuguese localization (bluesky-social#5256)

Co-authored-by: Henrique Marques <hfvmarques@gmail.com>
Co-authored-by: Arthur Tavares <arthurabreu00@gmail.com>

* Update French localization (bluesky-social#5227)

Co-authored-by: Stanislas Signoud <signez@stanisoft.net>

* Update Chinese localization (bluesky-social#5291)

Co-authored-by: cirx <133132480+cirx1e@users.noreply.github.com>
Co-authored-by: Kuwa Lee <kuwalee1069@gmail.com>

* Update Korean localization (bluesky-social#5254)

* Update Japanese translation (bluesky-social#5217)

* Update catalan messages.po (bluesky-social#5223)

Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
Co-authored-by: gsmt <samaritanojr006@gmail.com>

* Updates to Irish translation, back to 100% (bluesky-social#5345)

* [Video] Volume controls on web (bluesky-social#5363)

* split up VideoWebControls

* add basic slider

* logarithmic volume

* integrate mute state

* fix typo

* shared video volume

* rm log

* animate in/out

* disable for touch devices

* remove flicker on touch devices

* more detailed comment

* move into correct context provider

* add minHeight

* hack

* bettern umber

---------

Co-authored-by: Hailey <me@haileyok.com>

* [Video] Fix safari showing spinner (bluesky-social#5364)

* Milly tweaks (bluesky-social#5365)

Co-authored-by: Hailey <me@haileyok.com>

* [Video] Additional android fixes (bluesky-social#5373)

* rm unused code

* bump lib

* invert bool

* Bump 1.91.2 (bluesky-social#5387)

* Tweak `pt-BR` string (bluesky-social#5372)

* Pre-fill alt text with 10-million card post (bluesky-social#5389)

* Pre-fill alt text with 10-million card post (bluesky-social#5377)

* Clean up type

* Tweak alt copy

* Add pt translation, fix typo

---------

Co-authored-by: Calvin <clavin@users.noreply.github.com>

* Make like animation on web same speed as mobile (bluesky-social#5391)

* Fix border radius on avatars (bluesky-social#5392)

* Make it work with Xcode 16 (bluesky-social#5386)

* Temporary Sentry hack patch for iOS 18 (bluesky-social#5400)

* Revert unneeded changes to `expo-modules-core` patch (bluesky-social#5393)

* remove expo-sentry (bluesky-social#5405)

* Fix for undefined ref on hot reload on web (bluesky-social#5407)

* Update sentry sourcemaps upload (bluesky-social#5409)

* [Neue] Base (bluesky-social#5395)

* Add fontScale, gate it, fix some computes

* Add inter, integrate

* Clean up

* Apply to old Text component

* Use numeric weight

* Cleanup

* Clean up appearance settings

* Global tracking

* Fix regular italic variant

* Refactor settings and fontScale values

* Remove flags

* Get rid of lower weight font usage

* Remove gate from settings

* Refactor appearance settings for reuse

* Add neue type nux

* Update defaults

* Load fonts, add fallback families

* Load fonts via plugin in production

* Fixes

* Fix for web

* Nits

---------

Co-authored-by: Hailey <me@haileyok.com>

* Fix font loading on web (bluesky-social#5412)

* Copy font files during build

* Fall back if error loading fonts

* Fix ext embeds in DMs (bluesky-social#5419)

* fix ext embeds in DMs

* undo acciental rounding change

* Revert provider stacking changes (bluesky-social#5423)

* Remove expo/vector-icons from EditImage modal (bluesky-social#5422)

* [Neue] Ligatures & composer (bluesky-social#5427)

* Disable contextual ligatures

* Ensure new type styles are applied to the composer

* Clean up using real devices

* Feedback

* [Neue] Copy and spacing tweaks (bluesky-social#5428)

* Copy and spacing tweaks

* Copy tweaks

* Adjust toggle components sizing (bluesky-social#5408)

(cherry picked from commit a9cbd23)

* [Neue] Parallel font loading on web (bluesky-social#5411)

* Parallel font loading

(cherry picked from commit 10e2b05)

* Handle failures

* Rely on font-face and preload tags for font loading (bluesky-social#5431)

* Cache fonts for a year

* Add eslint rule to fix imports without the `#/` path alias (bluesky-social#5175)

* Add border to menu on web (bluesky-social#5439)

* Language fixes (bluesky-social#5384)

* Add some comments

* Decouple language settings

* Normalize on read/write

* Refactor

* Support device locale on app startup

* Cleanup, port to web

* Clean up comments

* Comment

* Try not to mutate

* Protect util handling, update test

* Dedupe array values

* Add explicit non-handling of detached quotes in embed (bluesky-social#5156)

* [Neue] Buttons (bluesky-social#5406)

* Re-align button sizing

(cherry picked from commit bcec243)

* Use large, small, tiny

(cherry picked from commit 1dc333c)

* Tweaks

* patch expo modules again (bluesky-social#5441)

* Additional moderation (bluesky-social#5172)

* Set up additional mod authorities

* Filter out non-configurable mod authorities

* WIP

* Working

* Cleanup, add mod

* Cleanup

* Add more debug logs

* Tweak logs

* Filter out imperative labels from typeaheads

* Filter hideable content from notifications

* Add api

* Fall back in dev

* Remove space

* Use prod endpoint

* Add tiny notice

* Add notice to labeler card, show all labelers

* Increase rounding for all embeds (bluesky-social#5421)

* tweak image styles

* fix reply image preview and covert to atoms

* increase rounding on media inset border

* decrease gap on desktop

* fix inset styles

* increase rounding on embeds to `md`

* Couple edge cases

---------

Co-authored-by: Eric Bailey <git@esb.lol>

* Fixing hover card for labeler accounts (bluesky-social#5414)

* Fixing hover card for labeler account

* removing memo

* Fixing extra spacing in notification text (bluesky-social#5396)

* Validate TLD in signup (bluesky-social#5426)

* add lib

* add validation

* log

* add some common typos

* add tests

* reset hasWarned state on edit

* shorten path

* Move test file, adjust regex, add test

* Get real nit picky

---------

Co-authored-by: Eric Bailey <git@esb.lol>

* Fix spacing (bluesky-social#5444)

* [Neue] Font weights (bluesky-social#5442)

* Align all font weights

* Only load necessary fonts

* Also comment out from hook

---------

Co-authored-by: Samuel Newman <mozzius@protonmail.com>
Co-authored-by: Hailey <me@haileyok.com>
Co-authored-by: Gargaj <gargaj@conspiracy.hu>
Co-authored-by: Eduardo Tachotte <58338880+0xEDU@users.noreply.github.com>
Co-authored-by: Eric Bailey <git@esb.lol>
Co-authored-by: Minseo Lee <itoupluk427@gmail.com>
Co-authored-by: dan <dan.abramov@gmail.com>
Co-authored-by: Wesley <46491851+wscld@users.noreply.github.com>
Co-authored-by: Paul Frazee <pfrazee@gmail.com>
Co-authored-by: Vinícius Souza <39967235+vinifsouza@users.noreply.github.com>
Co-authored-by: João Gabriel <joaog@nocorp.io>
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
Co-authored-by: Henrique Marques <hfvmarques@gmail.com>
Co-authored-by: Arthur Tavares <arthurabreu00@gmail.com>
Co-authored-by: Stanislas Signoud <signez@stanisoft.net>
Co-authored-by: Frudrax Cheng <i@cynosura.one>
Co-authored-by: cirx <133132480+cirx1e@users.noreply.github.com>
Co-authored-by: Kuwa Lee <kuwalee1069@gmail.com>
Co-authored-by: Takayuki KUSANO <65759+tkusano@users.noreply.github.com>
Co-authored-by: Ivan Beà <bea.ivan@gmail.com>
Co-authored-by: gsmt <samaritanojr006@gmail.com>
Co-authored-by: Kevin Scannell <kscanne@gmail.com>
Co-authored-by: Calvin <clavin@users.noreply.github.com>
Co-authored-by: Roscoe Rubin-Rottenberg <118622417+knotbin@users.noreply.github.com>
Co-authored-by: futur <me@futuristick.ca>
@kscanne kscanne deleted the irish-20240914 branch October 2, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surfdude29 surfdude29 surfdude29 left review comments

@haileyok haileyok haileyok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kscanne @surfdude29 @haileyok