-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Share Extension] Support on Android for sharing videos to app #5466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"file","filePath":"plugins/shareExtension/withIntentFilters.js","reasons":["expoConfigPlugins"],"hash":"5b20230825581abd85800a88c87cff7b249500c9"},{"type":"dir","filePath":"modules/expo-receive-android-intents/android","reasons":["expoAutolinkingAndroid"],"hash":"01923d854f7e5ed99ed327057dd87eb457034eba"}] Generated by PR labeler 🤖 |
|
arcalinea
temporarily deployed
to
hailey/share-extension-video-android - social-app PR #5466
September 26, 2024 22:13 — with
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/share-extension-video-android - social-app PR #5466
September 26, 2024 22:14 — with
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/share-extension-video-android - social-app PR #5466
September 26, 2024 22:14 — with
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/share-extension-video-android - social-app PR #5466
September 26, 2024 22:14 — with
Render
Destroyed
arcalinea
temporarily deployed
to
hailey/share-extension-video-android - social-app PR #5466
September 26, 2024 22:14 — with
Render
Destroyed
haileyok
changed the title
[Video] Share extension Android
[Share Extension] Support on Android for sharing videos to app
Sep 26, 2024
mozzius
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane, haven't tested
estrattonbailey
added a commit
that referenced
this pull request
Sep 30, 2024
* origin/main: Use Inter variable font (#5540) Fix name in `feature_request.yml` (#5542) Fix sticky offset, gear color (#5537) Move email test to root tests dir (#5527) revamp issue templates, add new arch template (#5532) use PressableScale for animation (#5541) Rework native autocomplete (#5521) Pinned posts (#5055) Remove Segment (#5518) Fix alignment of cancel button on search (#5520) [Share Extension] Support on Android for sharing videos to app (#5466) Ignore bogus onScroll values (#5499) add podcasts to spotify embeds (#5514) Tweak font size of "Write your reply" (#5513) Lazy load ViewShot (#5517) [Share Extension] Support images/movies from other apps like iMessage (#5515)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Just adding support for "Share to bluesky" for videos on Android
Test Plan
Try sharing a video into the app from photos app
Screen.Recording.2024-09-26.at.3.17.55.PM.mov