Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Share Extension] Support on Android for sharing videos to app #5466

Merged
merged 17 commits into from
Sep 27, 2024

Conversation

haileyok
Copy link
Contributor

@haileyok haileyok commented Sep 24, 2024

Why

Just adding support for "Share to bluesky" for videos on Android

Test Plan

Try sharing a video into the app from photos app

Screen.Recording.2024-09-26.at.3.17.55.PM.mov

Copy link

github-actions bot commented Sep 24, 2024

The Pull Request introduced fingerprint changes against the base commit:

Fingerprint diff
[{"type":"file","filePath":"plugins/shareExtension/withIntentFilters.js","reasons":["expoConfigPlugins"],"hash":"5b20230825581abd85800a88c87cff7b249500c9"},{"type":"dir","filePath":"modules/expo-receive-android-intents/android","reasons":["expoAutolinkingAndroid"],"hash":"01923d854f7e5ed99ed327057dd87eb457034eba"}]

Generated by PR labeler 🤖

Copy link

github-actions bot commented Sep 24, 2024

Old size New size Diff
10.43 MB 9.97 MB -473.63 KB (-4.43%)

@arcalinea arcalinea temporarily deployed to hailey/share-extension-video-android - social-app PR #5466 September 26, 2024 22:13 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/share-extension-video-android - social-app PR #5466 September 26, 2024 22:14 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/share-extension-video-android - social-app PR #5466 September 26, 2024 22:14 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/share-extension-video-android - social-app PR #5466 September 26, 2024 22:14 — with Render Destroyed
@arcalinea arcalinea temporarily deployed to hailey/share-extension-video-android - social-app PR #5466 September 26, 2024 22:14 — with Render Destroyed
@haileyok haileyok marked this pull request as ready for review September 26, 2024 22:14
@haileyok haileyok changed the title [Video] Share extension Android [Share Extension] Support on Android for sharing videos to app Sep 26, 2024
@haileyok haileyok requested a review from mozzius September 26, 2024 22:34
Copy link
Member

@mozzius mozzius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, haven't tested

@haileyok haileyok merged commit d8f72c1 into main Sep 27, 2024
6 checks passed
@haileyok haileyok deleted the hailey/share-extension-video-android branch September 27, 2024 16:54
estrattonbailey added a commit that referenced this pull request Sep 30, 2024
* origin/main:
  Use Inter variable font (#5540)
  Fix name in `feature_request.yml` (#5542)
  Fix sticky offset, gear color (#5537)
  Move email test to root tests dir (#5527)
  revamp issue templates, add new arch template (#5532)
  use PressableScale for animation (#5541)
  Rework native autocomplete (#5521)
  Pinned posts (#5055)
  Remove Segment (#5518)
  Fix alignment of cancel button on search (#5520)
  [Share Extension] Support on Android for sharing videos to app (#5466)
  Ignore bogus onScroll values (#5499)
  add podcasts to spotify embeds (#5514)
  Tweak font size of "Write your reply" (#5513)
  Lazy load ViewShot (#5517)
  [Share Extension] Support images/movies from other apps like iMessage (#5515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants