Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move email test to root tests dir #5527

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Move email test to root tests dir #5527

merged 1 commit into from
Sep 30, 2024

Conversation

haileyok
Copy link
Contributor

Having this test inside of /src breaks the dynamic import of tldts. Also, trying to use the dynamic import inside of the test itself - rather than just importing - causes a bunch of annoying problems with ESM modules, so let's just move it to the root test dir.

@arcalinea arcalinea temporarily deployed to hailey/fix-tldts-import - social-app PR #5527 September 28, 2024 16:49 — with Render Destroyed
Copy link

Old size New size Diff
9.71 MB 9.71 MB 0 B (0.00%)

@haileyok haileyok merged commit 669cdf2 into main Sep 30, 2024
6 checks passed
@haileyok haileyok deleted the hailey/fix-tldts-import branch September 30, 2024 20:56
estrattonbailey added a commit that referenced this pull request Sep 30, 2024
* origin/main:
  Use Inter variable font (#5540)
  Fix name in `feature_request.yml` (#5542)
  Fix sticky offset, gear color (#5537)
  Move email test to root tests dir (#5527)
  revamp issue templates, add new arch template (#5532)
  use PressableScale for animation (#5541)
  Rework native autocomplete (#5521)
  Pinned posts (#5055)
  Remove Segment (#5518)
  Fix alignment of cancel button on search (#5520)
  [Share Extension] Support on Android for sharing videos to app (#5466)
  Ignore bogus onScroll values (#5499)
  add podcasts to spotify embeds (#5514)
  Tweak font size of "Write your reply" (#5513)
  Lazy load ViewShot (#5517)
  [Share Extension] Support images/movies from other apps like iMessage (#5515)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants