Filter posts containing mute words from search and notifications #5599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Let me ask you a question. |
|
This is definitely a welcome change 🙏 Will it be a step towards fixing #3234? Or is that an entirely separate issue? 🤔 |
* origin/main: Make composer reducer source of truth for images/video when publishing (#5595) Track links and embeds in the composer reducer (#5593) Bump SDK (#5602) Update built asset caching (#5601) Downgrade sentry to recommended 5.24.3 (#5604) Add option to search in any language (#5598) Font tweaks (#5597)
arcalinea
temporarily deployed
to
mute-words-updates - social-app PR #5599
Render
Destroyed
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copies out the filtering and page reuse logic from
post-feed.tsinto these queries and applies post moderation to applicable data.Notifications handling
Muted users are already filtered out of notifications. This PR filters replies, quote posts, and mentions that contain muted words from the feed as well, meaning they are not shown at all.
Search handling
By applying
moderatePostto the search results, this PR filters out any posts by muted users, or posts containing muted words. Previously both were present in the results, though muted accounts did have aPostAlertspill on them showing "Account muted".However, if you search for a specific user e.g.
from:esb.lol, this filtering is NOT applied, though other post moderation like pills andContentHideris. The thinking here is to match what you get if you visit a muted users profile directly: you see all their posts, and posts containing mute words are hidden byContentHider.