Add graphic media self label #5758
Conversation
|
|
This is a welcome addition to self-labelling, thank you 🙏 Sorry for asking this here, as I realise it would be out-of-scope for this PR, but I was wondering if consideration is being given to increasing the visibility and discoverability of the self-label dialog, as suggested in #5383 and #5523? I think this could be pretty helpful in encouraging users to add content warnings where they're appropriate, and nicely complement the changes coming to the self-label dialog. |
|
That should not be mutually exclusive with adult content labels. |
|
@qazmlp yup, done |
|
@surfdude29 time dependent but yea, agree. |
arcalinea
temporarily deployed
to
hailey/add-gore-selflabel - social-app PR #5758
Render
Destroyed
|
Just testing this out on the preview branch, it's looking good! 👍 One slight issue I noticed: if a post has both
If it's possible to show the descriptions for both labels that would be ideal, but if not it's probably not much of a problem. |
|
If I have the time yea I'll adjust that in a separate PR. |
| updateAdultLabels: (labels: AdultSelfLabel[]) => void | ||
| updateOtherLabels: (labels: OtherSelfLabel[]) => void |
There was a problem hiding this comment.
Dig the naming change, v nice
| </Trans> | ||
| ) : ( | ||
| <Trans> | ||
| There are no self-labels that can be applied to this post. |
| postgate: AppBskyFeedPostgate.Record | ||
| threadgate: ThreadgateAllowUISetting[] | ||
| embed: EmbedDraft | ||
| } | ||
|
|
||
| export type ComposerAction = | ||
| | {type: 'update_richtext'; richtext: RichText} | ||
| | {type: 'update_labels'; labels: string[]} | ||
| | {type: 'update_labels'; labels: SelfLabel[]} |
arcalinea
temporarily deployed
to
hailey/add-gore-selflabel - social-app PR #5758
Render
Destroyed
Co-authored-by: Samuel Newman <mozzius@protonmail.com>
Co-authored-by: Samuel Newman <mozzius@protonmail.com>
Why
Adding the ability to self-label as graphic media.
There's some style questions here that are not really up my alley, open to any suggestions on how to make this thing look nice. Presumably we may add more labels alongside
Graphicin the future, so that is something to keep in mind.Functionally though, this should work.
Test Plan
Screen.Recording.2024-10-14.at.7.47.02.PM.mov
Screen.Recording.2024-10-14.at.7.47.51.PM.mov