Clean up drawer #5761
Merged
Clean up drawer #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mozzius
commented
Oct 15, 2024
•
mozzius
commented
- ALF'd most styles
- Made profile smaller, with extra bold display name
- Made slightly wider
- Made items closer together
- Added link to Chats screen (closes feat: adds chat menu item to web navigation drawer #5516)
| Before | After |
|---|---|
 |
 |
|
| return ( | ||
| <TouchableOpacity | ||
| <PressableScale |
There was a problem hiding this comment.
Personal opinion: not a huge fan of this animation here. What are your thoughts on this vs a background color on press?
* Avi stuff * Rm SafeAreaView, not working on Android * Dividers and spacing * Fix count on android, ended up refactoring the whole MenuItem * Litttttle more space * Improve NavSignupCard * format nit --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com>
arcalinea
temporarily deployed
to
samuel/drawer-cleanup - social-app PR #5761
Render
Destroyed
estrattonbailey
approved these changes
Oct 16, 2024
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* clean up drawer * add a lil bit of padding * Drawer nits (bluesky-social#5778) * Avi stuff * Rm SafeAreaView, not working on Android * Dividers and spacing * Fix count on android, ended up refactoring the whole MenuItem * Litttttle more space * Improve NavSignupCard * format nit --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> --------- Co-authored-by: Eric Bailey <git@esb.lol>
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* clean up drawer * add a lil bit of padding * Drawer nits (bluesky-social#5778) * Avi stuff * Rm SafeAreaView, not working on Android * Dividers and spacing * Fix count on android, ended up refactoring the whole MenuItem * Litttttle more space * Improve NavSignupCard * format nit --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> --------- Co-authored-by: Eric Bailey <git@esb.lol>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.