Drawer nits #5778
Merged
Drawer nits #5778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The Pull Request introduced fingerprint changes against the base commit: Fingerprint diff[{"type":"file","filePath":"package.json","reasons":["expoConfigPlugins"],"hash":"f9404ae1992b45bc15f713d6edc2c3ca65bb393e"},{"type":"dir","filePath":"modules/bottom-sheet/android","reasons":["expoAutolinkingAndroid"],"hash":"075af02074cfdb9692282a9f34648762ed0258b3"}]Generated by PR labeler 🤖 |
|
estrattonbailey
added a commit
that referenced
this pull request
Oct 17, 2024
* clean up drawer * add a lil bit of padding * Drawer nits (#5778) * Avi stuff * Rm SafeAreaView, not working on Android * Dividers and spacing * Fix count on android, ended up refactoring the whole MenuItem * Litttttle more space * Improve NavSignupCard * format nit --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> --------- Co-authored-by: Eric Bailey <git@esb.lol>
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* clean up drawer * add a lil bit of padding * Drawer nits (bluesky-social#5778) * Avi stuff * Rm SafeAreaView, not working on Android * Dividers and spacing * Fix count on android, ended up refactoring the whole MenuItem * Litttttle more space * Improve NavSignupCard * format nit --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> --------- Co-authored-by: Eric Bailey <git@esb.lol>
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* clean up drawer * add a lil bit of padding * Drawer nits (bluesky-social#5778) * Avi stuff * Rm SafeAreaView, not working on Android * Dividers and spacing * Fix count on android, ended up refactoring the whole MenuItem * Litttttle more space * Improve NavSignupCard * format nit --------- Co-authored-by: Samuel Newman <mozzius@protonmail.com> --------- Co-authored-by: Eric Bailey <git@esb.lol>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started as a fix for Android, ended up moving some things around. Main thing is removing the
SafeAreaView, idk why that wasn't working on Android. Totally my opinion here on space, open to feedback!