[Settings] Change handle dialog #5781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
surfdude29
reviewed
Oct 21, 2024
There was a problem hiding this comment.
These are two very pedantic suggested tweaks, so please feel free to ignore them: I think these two strings would look slightly better using an en dash rather than a hyphen. (I think most style guides would instead recommend an em dash in these cases, but I'm not sure that would fit Bluesky's style?)
|
I do love an em dash |
mozzius
force-pushed
the
samuel/settings-6
branch
from
12b9088 to
eb8b0a7
Compare
mozzius
force-pushed
the
samuel/settings-7
branch
from
bf21efe to
3c35db4
Compare
surfdude29
reviewed
Oct 28, 2024
mozzius
force-pushed
the
samuel/settings-6
branch
from
18954eb to
c86929b
Compare
mozzius
force-pushed
the
samuel/settings-7
branch
from
3c35db4 to
c226ffe
Compare
mozzius
force-pushed
the
samuel/settings-6
branch
from
c86929b to
940f0e8
Compare
mozzius
force-pushed
the
samuel/settings-7
branch
from
c226ffe to
7e033b5
Compare
mozzius
force-pushed
the
samuel/settings-6
branch
from
940f0e8 to
ba34813
Compare
|
Large font sizes make it quite hard to input a handle here, might need to adjust that. Also note the "Cancel" button gets kinda messed up w/ the header.
|
mozzius
force-pushed
the
samuel/settings-6
branch
from
ba34813 to
29669ad
Compare
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
mozzius
force-pushed
the
samuel/settings-7
branch
from
7e033b5 to
14d98fa
Compare
|
Fixed by setting a maxwidth. I'll fix the header separately
|
Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
mozzius
added a commit
that referenced
this pull request
Oct 31, 2024
* thread preferences screen * minor tweaks * more spacing * replace gate with IS_INTERNAL * [Settings] Following feed prefs revamp (#5773) * gated new settings screen * Following feed prefs * Update src/screens/Settings/FollowingFeedPreferences.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * Update src/screens/Settings/FollowingFeedPreferences.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * replace pref following feed gate * Update src/screens/Settings/FollowingFeedPreferences.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * use "Experimental" as the header --------- Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * [Settings] External media prefs revamp (#5774) * gated new settings screen * external media prefs revamp * replace gate ext media embeds * Update src/screens/Settings/ExternalMediaPreferences.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * add imports for translation * alternate list style on native --------- Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * [Settings] Languages revamp (partial) (#5775) * language settings (lazy restyle) * replace gate * fix text determining flex space * [Settings] App passwords revamp (#5777) * rework app passwords screen * Apply surfdude's copy changes Thanks @surfdude29! Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * format * replace gate * use admonition for input error and animate --------- Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * [Settings] Change handle dialog (#5781) * new change handle dialog * animations native only * overflow hidden on togglebutton animation * add a low-contrast border * extract out copybutton * finish change handle dialog * invalidate query on success * web fixes * error message for rate limit exceeded * typo * em dash! Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * another em dash Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * set maxwidth of suffixtext * Copy tweak Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> --------- Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * [Settings] Notifs settings revamp (#5884) * rename, move, and restyle notif settings * bold "experimental:" --------- Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5777
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-21.at.10.53.14.mp4