Settings revamp #5745

mozzius · 2024-10-14T12:37:06Z

Gated behind new_settings

Screens:

Dialogs:

Switch account (needs edit mode) Edit mode on switch account dialog #5881
Change password
Change handle [Settings] Change handle dialog #5781
Change email
Delete account
Add app password [Settings] App passwords revamp #5777
Select content languages

Other:

New <Select> component for languages screen

github-actions · 2024-10-14T12:51:39Z

Old size	New size	Diff
7.92 MB	7.98 MB	60.1 KB (0.74%)

src/screens/Settings/Settings.tsx

surfdude29

I noticed a few strings that could be marked for translation :)

src/screens/Settings/AccountSettings.tsx

mozzius · 2024-10-15T09:54:26Z

Thanks @surfdude29, forgot to mark them after copy/pasting out of the storybook :)

src/screens/Settings/PrivacyAndSecuritySettings.tsx

src/screens/Settings/ContentAndMediaSettings.tsx

surfdude29 · 2024-10-15T14:21:03Z

This looks really, really good, so much better than it is now, excellent work! 👌

I have one piece of feedback and one suggestion.

I'm not sure it's ideal to have the Accessibility and Appearance screens needing to be accessed via a sub-page rather than directly from the Settings screen. To me, they both seem important enough that the user should be able to access them directly.

I realise that it would add one more item to the main Settings screen and thus more scrolling would be necessary to see all the options, but my two cents are that it would be a worthwhile tradeoff. The in-app browser pref would fit nicely in Content and Media imo.

And my suggestion is to consider adding links to the Community Guidelines page and to the Copyright Policy page on the About screen.

This would not only make it more convenient to access these pages directly from the app, but it would also mean that the five Support screens could then be removed:

social-app/src/routes.ts

Lines 38 to 42 in 4c3c10d

    
           Support: '/support', 
        
           PrivacyPolicy: '/support/privacy', 
        
           TermsOfService: '/support/tos', 
        
           CommunityGuidelines: '/support/community-guidelines', 
        
           CopyrightPolicy: '/support/copyright',

Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>

haileyok · 2024-10-29T19:47:42Z

Can we stick some padding at the bottom of this screen? Final option feels a bit too close to the bottom.

haileyok · 2024-10-29T19:48:38Z

Nit. I think it feels a little off that the toggle isn't aligned with the first line here.

haileyok · 2024-10-29T19:51:50Z

Padding is off here on web

haileyok · 2024-10-29T19:52:27Z

Wonder if we could remove the inner border from this on web? Also let's add a close button maybe.

haileyok · 2024-10-29T19:53:55Z

Let's drop the background color on this (maybe you did in one of the following PRs though in which case ignore me)

haileyok

This is exceptionally good work. Sorry it took so long to start picking it up for review.

Looks good to go after checking the nits above.

haileyok · 2024-10-29T19:34:35Z

src/screens/Moderation/index.tsx

-        ]}>
-        <Trans>Logged-out visibility</Trans>
-      </Text>
+      {!IS_INTERNAL && (


Any reason for this?

nvm figured it out

haileyok · 2024-10-29T19:40:34Z

src/view/com/modals/DeleteAccount.tsx

@@ -210,6 +210,7 @@ export function Component({}: {}) {
                    to="#"
                    onPress={e => {
                      e.preventDefault()
+                      closeModal()


didnt look closely, but is this meant to be here?

Yeah it's broken on main lol

* origin/main: (213 commits) add Thai Language translation support (#5879) fix warning on labeler profile: emoji detected but emoji not enabled (#6011) Added blur to search's onPressMenu (#6017) React compiler beta and reenable rule (#5898) Sort imports (#6009) Clarify build instructions (#6008) Upgrade all tiptap deps to latest (#5232) width full on text container (#6007) Bump 1.94.0 (#6006) Add subtle web hover to interactive rows (#5989) Settings revamp (#5745) Show almost-instant preview when opening lightbox (#6000) Refactor lightbox model to plain object (#5999) temp revert to old modal (#6005) Extend composer checks to all posts in a thread (#5955) Remove indirection when rendering composer state (#5954) Refactor composer state for threads (#5945) Disable Post button when empty (#5953) fix splash screen (#5997) Fix video quality for short videos (#5996) ...

@surfdude29

* start building storybook * add title * add some styles * try out new icons * more settings list component parts * make text do the spacing * clean up storybook * gated new settings screen * switch account * add current profile * use Layout.Screen * Layout.Header and Layout.Content * translate helpdesk text thanks @surfdude29! Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * add account settings * undo changes to export car dialog * privacy and security screen * Translate protect account stuff Thanks @surfdude29! Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * content and media settings * about settings * 2fa copy Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * a11y and appearance * use new components for appearance settings * redesign accessibility settings * Update ContentAndMediaSettings.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * add divider * remove a11y and appearance middleman screen * fix web settingslist styles * new SettingsList.Group component * explain how portal magic works * hide pwioptout in old location * Update Settings.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * replace gate with `IS_INTERNAL` * add IS_INTERNAL to app-info.web * fix profile area growing * add close button to switch account --------- Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>

@surfdude29

* start building storybook * add title * add some styles * try out new icons * more settings list component parts * make text do the spacing * clean up storybook * gated new settings screen * switch account * add current profile * use Layout.Screen * Layout.Header and Layout.Content * translate helpdesk text thanks @surfdude29! Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * add account settings * undo changes to export car dialog * privacy and security screen * Translate protect account stuff Thanks @surfdude29! Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * content and media settings * about settings * 2fa copy Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * a11y and appearance * use new components for appearance settings * redesign accessibility settings * Update ContentAndMediaSettings.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * add divider * remove a11y and appearance middleman screen * fix web settingslist styles * new SettingsList.Group component * explain how portal magic works * hide pwioptout in old location * Update Settings.tsx Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com> * replace gate with `IS_INTERNAL` * add IS_INTERNAL to app-info.web * fix profile area growing * add close button to switch account --------- Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 14, 2024 12:37 — with Render Destroyed

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 14, 2024 12:43 — with Render Destroyed

arcalinea deployed to samuel/settings - social-app PR #5745 October 14, 2024 12:44 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 14, 2024 16:49 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 14, 2024 17:35 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 14, 2024 19:00 — with Render View deployment

mozzius force-pushed the samuel/settings branch from 4ffe292 to 2a0d8b3 Compare October 15, 2024 06:10

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 06:10 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 06:30 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 06:50 — with Render View deployment

surfdude29 reviewed Oct 15, 2024

View reviewed changes

src/screens/Settings/Settings.tsx Outdated Show resolved Hide resolved

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 15, 2024 08:23 — with Render Destroyed

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 08:29 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 08:56 — with Render View deployment

surfdude29 reviewed Oct 15, 2024

View reviewed changes

src/screens/Settings/AccountSettings.tsx Outdated Show resolved Hide resolved

src/screens/Settings/AccountSettings.tsx Outdated Show resolved Hide resolved

src/screens/Settings/AccountSettings.tsx Outdated Show resolved Hide resolved

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 15, 2024 09:46 — with Render Destroyed

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 09:54 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 10:13 — with Render View deployment

surfdude29 reviewed Oct 15, 2024

View reviewed changes

src/screens/Settings/PrivacyAndSecuritySettings.tsx Outdated Show resolved Hide resolved

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 15, 2024 10:46 — with Render Destroyed

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 15, 2024 10:48 — with Render Destroyed

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 15, 2024 11:00 — with Render Destroyed

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 11:13 — with Render View deployment

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 11:49 — with Render View deployment

mozzius marked this pull request as ready for review October 15, 2024 11:58

surfdude29 reviewed Oct 15, 2024

View reviewed changes

src/screens/Settings/ContentAndMediaSettings.tsx Outdated Show resolved Hide resolved

arcalinea deployed to samuel/settings - social-app PR #5745 October 15, 2024 13:58 — with Render View deployment

mozzius and others added 8 commits October 28, 2024 15:08

Update ContentAndMediaSettings.tsx

bc211eb

Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>

add divider

dae411f

remove a11y and appearance middleman screen

de71b08

fix web settingslist styles

2f16b1d

new SettingsList.Group component

dbb0a60

explain how portal magic works

aff5b0c

hide pwioptout in old location

8026f0f

Update Settings.tsx

5dc3035

Co-authored-by: surfdude29 <149612116+surfdude29@users.noreply.github.com>

mozzius force-pushed the samuel/settings branch from 817154b to 5dc3035 Compare October 28, 2024 15:08

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 28, 2024 15:08 — with Render Destroyed

replace gate with IS_INTERNAL

5fc1d2c

arcalinea deployed to samuel/settings - social-app PR #5745 October 28, 2024 15:10 — with Render View deployment

haileyok approved these changes Oct 29, 2024

View reviewed changes

add IS_INTERNAL to app-info.web

19171ea

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 29, 2024 21:01 — with Render Destroyed

fix profile area growing

4d0e0b6

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 29, 2024 21:02 — with Render Destroyed

add close button to switch account

bf212da

arcalinea temporarily deployed to samuel/settings - social-app PR #5745 October 29, 2024 21:10 — with Render Destroyed

mozzius merged commit c8f264b into main Oct 29, 2024
6 checks passed

mozzius deleted the samuel/settings branch October 29, 2024 21:14

auroursa mentioned this pull request Oct 30, 2024

Update Chinese & Cantonese localization #6015

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Settings revamp #5745

Settings revamp #5745

mozzius commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

surfdude29 left a comment

mozzius commented Oct 15, 2024

surfdude29 commented Oct 15, 2024

haileyok commented Oct 29, 2024

haileyok commented Oct 29, 2024

haileyok commented Oct 29, 2024

haileyok commented Oct 29, 2024 •

edited

Loading

haileyok commented Oct 29, 2024

haileyok left a comment

haileyok Oct 29, 2024

haileyok Oct 29, 2024

haileyok Oct 29, 2024

mozzius Oct 29, 2024

Settings revamp #5745

Settings revamp #5745

Conversation

mozzius commented Oct 14, 2024 • edited Loading

github-actions bot commented Oct 14, 2024 • edited Loading

surfdude29 left a comment

Choose a reason for hiding this comment

mozzius commented Oct 15, 2024

surfdude29 commented Oct 15, 2024

haileyok commented Oct 29, 2024

haileyok commented Oct 29, 2024

haileyok commented Oct 29, 2024

haileyok commented Oct 29, 2024 • edited Loading

haileyok commented Oct 29, 2024

haileyok left a comment

Choose a reason for hiding this comment

haileyok Oct 29, 2024

Choose a reason for hiding this comment

haileyok Oct 29, 2024

Choose a reason for hiding this comment

haileyok Oct 29, 2024

Choose a reason for hiding this comment

mozzius Oct 29, 2024

Choose a reason for hiding this comment

mozzius commented Oct 14, 2024 •

edited

Loading

github-actions bot commented Oct 14, 2024 •

edited

Loading

haileyok commented Oct 29, 2024 •

edited

Loading