Edit mode on switch account dialog #5881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
samuel/edit-accounts - social-app PR #5881
Render
Destroyed
|
|
It seems like it'd be prone to accidental taps, e.g. wanting to remove X account but ended up removing Y. |
|
The tap target is no different than the normal list? Do you think there should be a confirm prompt? |
|
Yeah, though I wonder if adding a confirmation might add too many taps? Considering how annoying it is to sign-in again it seems appropriate (unlocking password manager/remembering passwords, trying to fill it out..) |
arcalinea
temporarily deployed
to
samuel/edit-accounts - social-app PR #5881
Render
Destroyed
|
Closed in favour of #6131 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for settings redesign
Simulator.Screen.Recording.-.iPhone.16.-.2024-10-21.at.13.00.27.mp4