Check video state for the entire thread #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was referenced Oct 27, 2024
gaearon
force-pushed
the
thread-prepare-3
branch
from
0a44535 to
e78142f
Compare
gaearon
force-pushed
the
thread-prepare-4
branch
from
1f7ef60 to
9436363
Compare
gaearon
force-pushed
the
thread-prepare-3
branch
from
e78142f to
dfa7f48
Compare
gaearon
force-pushed
the
thread-prepare-4
branch
from
9436363 to
ddead5d
Compare
gaearon
force-pushed
the
thread-prepare-3
branch
from
dfa7f48 to
6c71f28
Compare
gaearon
force-pushed
the
thread-prepare-4
branch
from
ddead5d to
eada192
Compare
gaearon
force-pushed
the
thread-prepare-4
branch
from
eada192 to
ed9a2ae
Compare
gaearon
force-pushed
the
thread-prepare-4
branch
from
ed9a2ae to
8311017
Compare
haileyok
approved these changes
Oct 31, 2024
arcalinea
temporarily deployed
to
thread-prepare-4 - social-app PR #5957
Render
Destroyed
gaearon
force-pushed
the
thread-prepare-4
branch
from
2c22810 to
8311017
Compare
arcalinea
temporarily deployed
to
thread-prepare-4 - social-app PR #5957
Render
Destroyed
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Switch to using post ID for post actions * Pass post-bound dispatch to ComposerPost * Check video state for entire thread * Always bind post actions to an ID * Rename variable for consistency * Fix clashing keys
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Switch to using post ID for post actions * Pass post-bound dispatch to ComposerPost * Check video state for entire thread * Always bind post actions to an ID * Rename variable for consistency * Fix clashing keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #5953, #5945, #5954, and #5955
Same as #5955 but for videos.
Test Plan
Go through the usual flows with a single video. Upload it, change dimensions, post while uploading too, etc.
Also verify error path works too. And clearing errors.