Disable Post button when empty #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
commented
Oct 26, 2024
| return | ||
| } | ||
|
|
||
| if (isAltTextRequiredAndMissing) { |
There was a problem hiding this comment.
both removed conditions are a part of !canPost now
|
This was referenced Oct 26, 2024
gaearon
force-pushed
the
rm-empty-post-error
branch
from
172d464 to
b29f159
Compare
|
Found a case where it's not disabled while empty - video errors 
|
|
I think we should probably disable posting if there's an error in general? Empty or not. Clear/ack the error, then post. |
arcalinea
temporarily deployed
to
rm-empty-post-error - social-app PR #5953
Render
Destroyed
|
Pushed. |
estrattonbailey
added a commit
that referenced
this pull request
Oct 31, 2024
* origin/main: (213 commits) add Thai Language translation support (#5879) fix warning on labeler profile: emoji detected but emoji not enabled (#6011) Added blur to search's onPressMenu (#6017) React compiler beta and reenable rule (#5898) Sort imports (#6009) Clarify build instructions (#6008) Upgrade all tiptap deps to latest (#5232) width full on text container (#6007) Bump 1.94.0 (#6006) Add subtle web hover to interactive rows (#5989) Settings revamp (#5745) Show almost-instant preview when opening lightbox (#6000) Refactor lightbox model to plain object (#5999) temp revert to old modal (#6005) Extend composer checks to all posts in a thread (#5955) Remove indirection when rendering composer state (#5954) Refactor composer state for threads (#5945) Disable Post button when empty (#5953) fix splash screen (#5997) Fix video quality for short videos (#5996) ...
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Disable Post button when empty * Use regular disabled button * Disable post on video error until cleared
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Disable Post button when empty * Use regular disabled button * Disable post on video error until cleared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This in preparation for the threaded composer. It doesn't quite make sense to treat this as an error — we should just prevent you from posting, same as we do in other invalid cases (like too long post or missing ALT).
In the second commit, I'm also replacing ad-hoc grey disabled styling with our normal disabled button. We've already been using the disabled button for the case when you pressed post so let's use it here too.
Test Plan
Observe the initial state.
Verify that typing makes the button enabled.
Verify existing flows (adding image, filling alt, adding video, posting before it's uploaded) work like before.