Refactor composer state for threads #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcalinea
temporarily deployed
to
thread-prepare - social-app PR #5945
Render
Destroyed
gaearon
commented
Oct 25, 2024
| dispatch={dispatch} | ||
| post={draft} | ||
| thread={composerState.thread} | ||
| dispatch={composerDispatch} |
There was a problem hiding this comment.
In most cases we pass the "post" dispatch but here it needs the broader one to set post/threadgates. I'm just calling it dispatch everywhere though. Might be a bit confusing but types clarify which one it needs.
|
arcalinea
temporarily deployed
to
thread-prepare - social-app PR #5945
Render
Destroyed
arcalinea
temporarily deployed
to
thread-prepare - social-app PR #5945
Render
Destroyed
gaearon
force-pushed
the
thread-prepare
branch
from
9ef8fef to
0ac363f
Compare
gaearon
force-pushed
the
thread-prepare
branch
from
0ac363f to
640b71d
Compare
This was referenced Oct 26, 2024
gaearon
force-pushed
the
rm-empty-post-error
branch
from
172d464 to
b29f159
Compare
gaearon
force-pushed
the
thread-prepare
branch
from
640b71d to
4086255
Compare
gaearon
force-pushed
the
thread-prepare
branch
from
4086255 to
cb6afc1
Compare
haileyok
approved these changes
Oct 29, 2024
TS can see it's exhaustive.
gaearon
force-pushed
the
thread-prepare
branch
from
cb6afc1 to
48ee82d
Compare
arcalinea
temporarily deployed
to
thread-prepare - social-app PR #5945
Render
Destroyed
estrattonbailey
added a commit
that referenced
this pull request
Oct 31, 2024
* origin/main: (213 commits) add Thai Language translation support (#5879) fix warning on labeler profile: emoji detected but emoji not enabled (#6011) Added blur to search's onPressMenu (#6017) React compiler beta and reenable rule (#5898) Sort imports (#6009) Clarify build instructions (#6008) Upgrade all tiptap deps to latest (#5232) width full on text container (#6007) Bump 1.94.0 (#6006) Add subtle web hover to interactive rows (#5989) Settings revamp (#5745) Show almost-instant preview when opening lightbox (#6000) Refactor lightbox model to plain object (#5999) temp revert to old modal (#6005) Extend composer checks to all posts in a thread (#5955) Remove indirection when rendering composer state (#5954) Refactor composer state for threads (#5945) Disable Post button when empty (#5953) fix splash screen (#5997) Fix video quality for short videos (#5996) ...
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Refactor composer state for threads * Remove unnecessary default case TS can see it's exhaustive.
rshigg
pushed a commit
to rshigg/social-app
that referenced
this pull request
Nov 2, 2024
* Refactor composer state for threads * Remove unnecessary default case TS can see it's exhaustive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked on #5953
This prepares the composer state structure to handle multiple posts in a thread. Previously we just had the
draft. Now we have athreadmade ofposts.Most of the reducer logic is now in
postReducerwhich updatesPostStatein response toPostAction. ThepostReduceris being called for the current post from the outercomposerReducer.We're not actually taking advantage of this in the UI yet. The UI is the same and it only reads the current post's state (which is always the first post because we don't have any logic to add/remove posts yet).
Also, the publishing code only looks at the first post at the moment. That will be changed later.
Test Plan
Same as usual, verify different composer features work.