Skip to content

Commit dbcf8fb

Browse files
AntonAnton
authored andcommitted
Merge pull request #247 from AntonShevchuk/master
Prepare Response object for PSR-7
2 parents eea989b + 793d3a3 commit dbcf8fb

File tree

14 files changed

+456
-88
lines changed

14 files changed

+456
-88
lines changed

src/Application/Application.php

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -704,20 +704,20 @@ public function process()
704704
$response->setException($e);
705705

706706
if ($request->isXmlHttpRequest()) {
707-
$response->setCode(204);
707+
$response->setStatusCode(204);
708708
$response->setHeader('Bluz-Redirect', $e->getMessage());
709709
} else {
710-
$response->setCode($e->getCode());
710+
$response->setStatusCode($e->getCode());
711711
$response->setHeader('Location', $e->getMessage());
712712
}
713713
} catch (ReloadException $e) {
714714
$response->setException($e);
715715

716716
if ($request->isXmlHttpRequest()) {
717-
$response->setCode(204);
717+
$response->setStatusCode(204);
718718
$response->setHeader('Bluz-Reload', 'true');
719719
} else {
720-
$response->setCode($e->getCode());
720+
$response->setStatusCode($e->getCode());
721721
$response->setHeader('Refresh', '15; url=' . $request->getRequestUri());
722722
}
723723
} catch (\Exception $e) {
@@ -737,8 +737,8 @@ public function process()
737737
$dispatchResult = $this->getLayout();
738738
}
739739

740-
$response->setCode($e->getCode())
741-
->setBody($dispatchResult);
740+
$response->setStatusCode($e->getCode());
741+
$response->setBody($dispatchResult);
742742
}
743743

744744
return $this->getResponse();

src/Cli/Response.php

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
*/
1212
namespace Bluz\Cli;
1313

14-
use Bluz\Messages\Messages;
1514
use Bluz\Response\AbstractResponse;
1615
use Bluz\View\View;
1716

@@ -32,29 +31,15 @@ class Response extends AbstractResponse
3231
*/
3332
protected function sendHeaders()
3433
{
35-
// output messages if exists
36-
if (app()->hasMessages()) {
37-
$messages = app()->getMessages()->popAll();
38-
foreach ($messages as $type => $stack) {
39-
if (!sizeof($stack)) {
40-
continue;
41-
}
42-
echo "\n";
43-
switch ($type) {
44-
case Messages::TYPE_ERROR:
45-
echo Colorize::text("Errors ", "white", "red", true);
46-
break;
47-
case Messages::TYPE_NOTICE:
48-
echo Colorize::text("Info ", "white", "blue", true);
49-
break;
50-
case Messages::TYPE_SUCCESS:
51-
echo Colorize::text("Success ", "white", "green", true);
52-
break;
53-
}
54-
echo ":\n\t";
55-
echo join("\n\t", $stack);
34+
// output headers
35+
foreach ($this->getHeaders() as $name => $value) {
36+
if (!sizeof($value)) {
37+
continue;
5638
}
57-
echo "\n\n";
39+
echo $name .": ". join(', ', $value) ."\n";
40+
}
41+
if (sizeof($this->headers)) {
42+
echo "\n";
5843
}
5944
}
6045

@@ -76,14 +61,12 @@ protected function sendBody()
7661
if (is_array($response)) {
7762
// just print to console
7863
foreach ($response as $key => $value) {
79-
echo Colorize::text($key, "yellow", null, true) . ": ";
64+
echo $key . ": ";
8065
print_r($value);
8166
echo "\n";
8267
}
8368
} else {
84-
echo Colorize::text("Response", "yellow", null, true) . ": ";
8569
print_r($response);
86-
echo "\n";
8770
}
8871
}
8972
}

src/Controller/Rest.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -152,11 +152,11 @@ public function __invoke()
152152
}
153153

154154
} catch (ValidatorException $e) {
155-
app()->getResponse()->setCode(400);
155+
app()->getResponse()->setStatusCode(400);
156156
return ['errors' => $e->getErrors()];
157157
}
158158

159-
app()->getResponse()->setCode(201);
159+
app()->getResponse()->setStatusCode(201);
160160
app()->getResponse()->setHeader(
161161
'Location',
162162
app()->getRouter()->url($request->getModule(), $request->getController()).'/'.$result
@@ -180,10 +180,10 @@ public function __invoke()
180180
// if $result === 0 it's means a update is not apply
181181
// or records not found
182182
if (0 === $result) {
183-
app()->getResponse()->setCode(304);
183+
app()->getResponse()->setStatusCode(304);
184184
}
185185
} catch (ValidatorException $e) {
186-
app()->getResponse()->setCode(400);
186+
app()->getResponse()->setStatusCode(400);
187187
return ['errors' => $e->getErrors()];
188188
}
189189
return false; // disable view
@@ -201,7 +201,7 @@ public function __invoke()
201201
}
202202
$this->deleteSet($this->data);
203203
}
204-
app()->getResponse()->setCode(204);
204+
app()->getResponse()->setStatusCode(204);
205205
return false; // disable view
206206
default:
207207
throw new NotImplementedException();

src/Http/Response.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ protected function sendHeaders()
4141

4242
// Send stored headers
4343
foreach ($this->headers as $key => $value) {
44-
header($key .': '. $value);
44+
header($key .': '. join(', ', $value));
4545
}
4646
}
4747

0 commit comments

Comments
 (0)