refactor(installer): remove dead agent compilation pipeline#2080
Merged
refactor(installer): remove dead agent compilation pipeline#2080
Conversation
Delete 9 files (~2,600 lines) that compiled .agent.yaml to .md. No .agent.yaml files exist in the source tree — agents now ship as pre-built SKILL.md. Clean up all references in installer, module manager, custom handler, base IDE, UI, and tests.
🤖 Augment PR SummarySummary: This PR removes the legacy “agent compilation” pipeline that previously transformed Changes:
Technical Notes: After this refactor, agent installation assumes agents are already in their final 🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
📝 WalkthroughWalkthroughThis change removes the entire YAML-to-XML agent compilation infrastructure, including builders, analyzers, template engines, and associated installer/compiler modules. The CLI command no longer supports the Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tools/cli/installers/lib/modules/manager.js (1)
697-710:⚠️ Potential issue | 🟡 MinorRemove the unused
vendorCrossModuleWorkflows()method and its call site.This method searches for
.agent.yamlor.yamlfiles in theagents/directory, but the agent migration changed all agents to.mdformat. Since no YAML files exist post-migration and noworkflow-installmetadata remains anywhere in the codebase, the method silently returns early (line 712) without processing anything. The call at line 462 ininstall()has no effect and should be removed along with the method definition (lines 697–800+ in manager.js).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@tools/cli/installers/lib/modules/manager.js` around lines 697 - 710, Remove the dead vendorCrossModuleWorkflows workflow code and its invocation: delete the vendorCrossModuleWorkflows(...) method definition and remove its call inside the install() function so no unused YAML-agent migration logic remains; ensure you search for and remove references to the vendorCrossModuleWorkflows symbol and update any exports if the method is exported (e.g., remove from module.exports or class methods) to avoid dangling references or lint errors.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@tools/cli/installers/lib/custom/handler.js`:
- Around line 144-151: The current agent count uses
findFilesRecursively(agentsDir, ['.md']) and overcounts because SKILL.md-based
agents include multiple markdown files; change the counting logic to count agent
entrypoints instead by scanning immediate subdirectories of agentsDir for a
SKILL.md (or other defined entrypoint filename) rather than all .md files —
update the code around agentsDir, findFilesRecursively, copyDirectory and
results.agentsInstalled so results.agentsInstalled = number of subdirectories
under agentsDir that contain SKILL.md (or configured entrypoint), and ensure
workflowsInstalled logic is not incremented for those SKILL.md files (i.e.,
treat SKILL.md as an agent entrypoint, not a workflow file).
---
Outside diff comments:
In `@tools/cli/installers/lib/modules/manager.js`:
- Around line 697-710: Remove the dead vendorCrossModuleWorkflows workflow code
and its invocation: delete the vendorCrossModuleWorkflows(...) method definition
and remove its call inside the install() function so no unused YAML-agent
migration logic remains; ensure you search for and remove references to the
vendorCrossModuleWorkflows symbol and update any exports if the method is
exported (e.g., remove from module.exports or class methods) to avoid dangling
references or lint errors.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: ae27d74a-13c0-4c0d-931f-6525dc2493b4
📒 Files selected for processing (16)
test/test-installation-components.jstools/cli/commands/install.jstools/cli/installers/lib/core/installer.jstools/cli/installers/lib/custom/handler.jstools/cli/installers/lib/ide/_base-ide.jstools/cli/installers/lib/modules/manager.jstools/cli/lib/activation-builder.jstools/cli/lib/agent-analyzer.jstools/cli/lib/agent-party-generator.jstools/cli/lib/agent/compiler.jstools/cli/lib/agent/installer.jstools/cli/lib/agent/template-engine.jstools/cli/lib/ui.jstools/cli/lib/xml-handler.jstools/cli/lib/xml-to-markdown.jstools/cli/lib/yaml-xml-builder.js
💤 Files with no reviewable changes (11)
- tools/cli/installers/lib/ide/_base-ide.js
- tools/cli/lib/agent-analyzer.js
- tools/cli/lib/ui.js
- tools/cli/lib/activation-builder.js
- tools/cli/lib/agent/compiler.js
- tools/cli/lib/xml-to-markdown.js
- tools/cli/lib/xml-handler.js
- tools/cli/lib/yaml-xml-builder.js
- tools/cli/lib/agent/installer.js
- tools/cli/lib/agent/template-engine.js
- tools/cli/lib/agent-party-generator.js
CustomHandler.install(), copyDirectory(), and findFilesRecursively() are never called — custom modules are installed via moduleManager.install() since Dec 2025. Also removes unused FileOps import and constructor. Verified with before/after clean-installer comparison (codex + custom modules with custom.yaml): output is identical. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ager Address review findings from PR #2080 triage: - Remove compile-agents from CLI action docs (en, fr, zh-cn) - Remove dead vendorCrossModuleWorkflows() and .agent.yaml skip logic - Clean stale compilation-era comments in manifest-generator
Collaborator
Author
Triage Results — Review FindingsTriaged all 6 findings from Augment and CodeRabbit reviews. Summary:
Commits: Custom-content install baseline verified identical (timestamps-only diff) before and after triage fixes. |
This was referenced Mar 21, 2026
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.agent.yaml→.md— no.agent.yamlfiles exist in the source tree anymorecompileAgents,compileModuleAgents,copySidecarToMemory,findAgentFiles,processAgentFiles,getAgentCommandHeader,compileAndCopyAgentsmethodscompile-agentsaction from CLI and UIXmlHandlerandfilterCustomizationDataimports from 4 installer filescopyCoreFilesYamlXmlBuilderdependency and dead test suitesTest plan
npm run qualitypasses (lint, format, markdown lint, docs build, 231 install tests, ref validation, skill validation)grep -rconfirms zero remaining references to removed symbols