refactor(installer): remove dead task/tool/workflow manifest code

[alexeyv]

Summary

• Remove collectTasks(), collectTools(), collectWorkflows() and their helpers (getTasksFromDir, getToolsFromDir, getWorkflowsFromPath) from manifest-generator.js — these scan for artifacts that no longer exist after the skill-manifest-yaml removal
• Remove writeTaskManifest(), writeToolManifest(), writeWorkflowManifest() and the now-unreachable getPreservedCsvRows()/upgradeRowToSchema() methods
• Remove pre-registration of workflow-manifest.csv and task-manifest.csv in installer.js
• Update test fixtures and assertions that referenced the removed manifests and collector arrays

Net: -659 lines, clean installs no longer produce empty task-manifest.csv, tool-manifest.csv, or workflow-manifest.csv.

Test plan

• npm run quality passes (all 227 tests, lint, format, docs build, ref validation, skill validation)
• Grep confirms no remaining references to task-manifest.csv, tool-manifest.csv, or workflow-manifest.csv outside the deleted code

[augmentcode]

🤖 Augment PR Summary

Summary: Refactors the installer’s manifest pipeline to remove legacy workflow/task/tool CSV generation that’s no longer meaningful after the skill-manifest YAML migration.

Changes:

• Removed workflow/task/tool discovery collectors and their helpers from tools/cli/installers/lib/core/manifest-generator.js.
• Removed CSV writers for workflow-manifest.csv, task-manifest.csv, and tool-manifest.csv, plus related schema-preservation logic.
• Updated manifest generation to emit only manifest.yaml, skill-manifest.csv, agent-manifest.csv, and files-manifest.csv.
• Stopped pre-registering the removed CSVs as installed artifacts in installer.js.
• Adjusted installation component tests/fixtures and assertions to stop referencing removed manifests and collector arrays.

Technical Notes: Net effect is a smaller, clearer install footprint—clean installs no longer produce empty workflow/task/tool manifest CSVs, while still generating agent/skill manifests and a hashed files-manifest.csv.

_{🤖 Was this summary useful? React with 👍 or 👎}

[augmentcode]

Review completed. 1 suggestion posted.

Comment augment review to trigger a new review at any time.

[augmentcode]

With the workflow/task/tool collectors removed, this.files now only contains skills/agents; when generateManifests() is called with an empty installedFiles list, files-manifest.csv will omit other installed artifacts (e.g., workflows/**). If installedFiles is meant to be optional, consider whether the fallback path still needs to produce a complete file manifest.

Severity: medium

_{🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0e1db94f-c925-4d62-8fcc-13ac4a3ab1b8

📥 Commits

Reviewing files that changed from the base of the PR and between 31ae226 and 8aa8dcd.

📒 Files selected for processing (3)

• test/test-installation-components.js
• tools/cli/installers/lib/core/installer.js
• tools/cli/installers/lib/core/manifest-generator.js

---

📝 Walkthrough

Walkthrough

The changes remove support for generating workflow, task, and tool CSV manifests in the installer system. Manifest generation now outputs only skills and agents, with related tests and fixture creation updated accordingly.

Changes

Cohort / File(s)	Summary
Manifest Generation Simplification tools/cli/installers/lib/core/manifest-generator.js, tools/cli/installers/lib/core/installer.js	Removed all collection and CSV generation logic for workflows, tasks, and tools. Manifest generation now produces only skill-manifest.csv and agent-manifest.csv outputs. Pre-registration of workflow and task manifests in installer config removed.
Test Fixture Updates test/test-installation-components.js	Removed creation of workflow, task, and tool CSV files in fixture setup. Test assertions updated to remove expectations for exclusion behavior of skills in workflows[] and tasks[] arrays, while retaining validations for skills in skills[] array.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• PR #2078: Directly removes legacy workflow/task/tool collection and generation while simplifying installer flows and updating related tests.
• PR #1859: Adds collectSkills flow and makes legacy collectors skip skill-claimed directories, affecting how workflows/tasks/tools are handled in manifest generation.
• PR #1851: Handles skill-manifest.csv and excludes skill entries from workflow manifests, addressing related manifest output changes.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch remove-dead-manifest-code

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}