Conversation
|
coverage: 74.815% (+0.2%) from 74.59% — fuzz into main |
A number of `uint64` values read from the file are used for sizing slices however really large values will induce a panic which can happen when fuzzing. For now, check these values are no greater than `math.MaxUint32` which is safely within the Golang limit for slices and probably large enough. Some values also should be greater than zero so add an additional check for that where necessary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of
uint64values read from the file are used for sizingslices however really large values will induce a panic which can happen
when fuzzing.
For now, check these values are no greater than
math.MaxUint32whichis safely within the Golang limit for slices and probably large enough.
Some values also should be greater than zero so add an additional check
for that where necessary.