Skip to content

Conversation

bill-rich
Copy link

No description provided.

@bodgit
Copy link
Owner

bodgit commented Dec 6, 2023

Ideally I need some sort of archive to verify what's going on here. There's three different structs that can all potentially contain a digest value so I don't know if in this case I'm supposed to use a digest value from one of the other structs.

Just being able to run 7z l -slt archive.7z and seeing if there's a CRC = ... line printed would indicate there's a CRC value somewhere in the metadata.

@coveralls
Copy link

coveralls commented Dec 6, 2023

Coverage Status

coverage: 71.461% (+0.04%) from 71.418%
when pulling 24c0243 on bill-rich:check_if_digest_exists
into 48cd5d1 on bodgit:main.

@bodgit bodgit force-pushed the check_if_digest_exists branch from 57dc488 to 24c0243 Compare December 6, 2023 11:06
Copy link

github-actions bot commented Dec 6, 2023

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "Check if digest has element j". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@bodgit bodgit added bug Something isn't working duplicate This issue or pull request already exists labels Dec 12, 2023
@bodgit
Copy link
Owner

bodgit commented Dec 12, 2023

I've released https://github.com/bodgit/sevenzip/releases/tag/v1.4.5 which should have a similar fix to this.

@bodgit bodgit closed this Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants