Skip to content

Conversation

@hyperz111
Copy link
Contributor

Fixes #115

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: 7634791

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clack/prompts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Sep 5, 2025

@example/basic@example/changesets

npm i https://pkg.pr.new/bombshell-dev/clack/@clack/core@391
npm i https://pkg.pr.new/bombshell-dev/clack/@clack/prompts@391

commit: 7634791

@hyperz111
Copy link
Contributor Author

@43081j, do we need to add tests?

@43081j
Copy link
Collaborator

43081j commented Sep 8, 2025

we should add a test for each of the two prompts that basically contains a wide character i think

e.g. it could set the max columns to 10 or something, and output 5 or 6 wide chars to prove it goes across 2 lines

@hyperz111
Copy link
Contributor Author

@43081j, can you merge this?

@43081j 43081j merged commit d25f6d0 into bombshell-dev:main Sep 8, 2025
7 checks passed
@hyperz111 hyperz111 deleted the note-box-cjk branch September 8, 2025 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] note prompt box witdth compute incorrect when title contains Chinese

2 participants