Skip to content

fix: add per-org upload pattern defaults for book_per_folder mode#33

Merged
neonsolstice merged 3 commits into
mainfrom
BO-22-default-file-naming-pattern-breaks-series-in-folder-per-book-libraries
May 18, 2026
Merged

fix: add per-org upload pattern defaults for book_per_folder mode#33
neonsolstice merged 3 commits into
mainfrom
BO-22-default-file-naming-pattern-breaks-series-in-folder-per-book-libraries

Conversation

@neonsolstice
Copy link
Copy Markdown
Collaborator

@neonsolstice neonsolstice commented May 18, 2026

Introduces a second global upload pattern for book_per_folder libraries.
The default pattern ends with a trailing slash, which causes resolveUploadPath
to place each book in its own subfolder - matching the expectation of the
book_per_folder scanner mode.

Changes:

  • Add DEFAULT_UPLOAD_PATTERN_BOOK_PER_FOLDER constant (packages/types)
  • Add UPLOAD_FILE_PATTERN_BOOK_PER_FOLDER setting key and service methods
  • Add GET/PUT /api/app-settings/upload-pattern-folder endpoints
  • Make upload and book-dock services select the correct global pattern based
    on library.organizationMode (lazy evaluation via ?? conditional)
  • Expose both patterns in File Naming Settings admin UI (one row per mode)
  • Add tests for all new behaviour

Closes #22

@neonsolstice neonsolstice added the bug Something isn't working label May 18, 2026
@github-actions github-actions Bot added ci Changes to CI/CD workflows, automation, or developer tooling. server Changes affecting server-side code, APIs, or backend behavior. client Changes affecting the client application or frontend behavior. packages and removed bug Something isn't working labels May 18, 2026
@neonsolstice neonsolstice changed the title fix: add per-org-mode upload pattern defaults to fix book_per_folder naming fix: add per-org upload pattern defaults for book_per_folder mode May 18, 2026
@neonsolstice
Copy link
Copy Markdown
Collaborator Author

neonsolstice commented May 18, 2026

Closing briefly to retrigger CI with updated PR title.

@neonsolstice neonsolstice reopened this May 18, 2026
@neonsolstice neonsolstice force-pushed the BO-22-default-file-naming-pattern-breaks-series-in-folder-per-book-libraries branch from cf88090 to 2b7db10 Compare May 18, 2026 17:50
@neonsolstice
Merge branch 'main' into BO-22-default-file-naming-pattern-breaks-ser…
69b368e 
…ies-in-folder-per-book-libraries

Signed-off-by: neon <18559658+neonsolstice@users.noreply.github.com>
@neonsolstice neonsolstice merged commit 93b7ba3 into main May 18, 2026
11 checks passed
@neonsolstice neonsolstice deleted the BO-22-default-file-naming-pattern-breaks-series-in-folder-per-book-libraries branch May 18, 2026 23:12
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 19, 2026

🎉 This PR is included in version 1.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions Bot added the released Issue or PR is included in a released version. label May 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

ci Changes to CI/CD workflows, automation, or developer tooling. client Changes affecting the client application or frontend behavior. packages released Issue or PR is included in a released version. server Changes affecting server-side code, APIs, or backend behavior.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Default File Naming Pattern Breaks Series in Folder Per Book Libraries

1 participant

@neonsolstice