Skip to content

Conversation

@LURKS02
Copy link
Collaborator

@LURKS02 LURKS02 commented Dec 5, 2024

관련 이슈

✅ 완료 및 수정 내역

  • Preview 화면 구현
  • VideoMerger 에러 수정

🛠️ 테스트 방법

  • 첫 화면부터 연결하여 테스트 하였습니다.

📝 리뷰 노트

  • VideoMerger 수정
    NaturalSize에서 정확한 값을 얻어오지 않아 윤회님이 주신 코드 참조하여 수정하였습니다. (감사합니다!)
  • 종료 화면
    정상적으로 저장이 완료되었을 때만 넘어갑니다.

📱 스크린샷(선택)

ScreenRecording_12-06-2024.01-40-23_1.MP4

Copy link
Collaborator

@051198Hz 051198Hz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

특별히 수정할 점 없어보여 승인드립니다~
고생 많으셨습니다!

}

func setupMainLabel() {
mainLabel.text = "성공적으로\n동영상을 저장했어요! 🥳"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋ

Copy link
Collaborator

@around-forest around-forest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

Copy link
Collaborator

@jungseokyoung-cloud jungseokyoung-cloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@LURKS02 LURKS02 merged commit 2c925b8 into develop Dec 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants