Skip to content

♻️ refactor: 디렉토리 구조 controller, service, repository, module 분리 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 7, 2025
Merged

♻️ refactor: 디렉토리 구조 controller, service, repository, module 분리 #1

merged 3 commits into from
Jan 7, 2025

Conversation

@Jo-Minseok
Copy link
Member

@Jo-Minseok Jo-Minseok commented Jan 7, 2025 •
edited
Loading

🔨 테스크

디렉토리 구조 변경

  • 서비스에 필요한 기능들을 넣다 보니 점점 하나의 도메인 디렉토리가 비대해지는 것을 확인했다.
  • 하나의 도메인 디렉토리 안에서 많은 소스 코드 파일 존재 문제로, 도메인 내에서 이용 목적에 따라 디렉토리를 나눠 추후에 있을 서비스 확장을 고려했다.
  • 메인 디렉토리 변경으로 테스트 코드의 import 경로가 바뀌는데, 어짜피 나중에 유닛 테스트 확장성을 고려해 테스트 안에서도 E2E 디렉토리로 분리했다.

📋 작업 내용

  • admin-api-docs 제거
  • 디렉토리 구조 controller, service, repository, module 분리
  • 단위 테스트 확장성을 고려해 test 디렉토리도 e2e 디렉토리 분리

📷 스크린 샷(선택 사항)

image

@Jo-Minseok Jo-Minseok added the 🔨 Refactor 리팩토링 (구조 변경) label Jan 7, 2025
@Jo-Minseok Jo-Minseok self-assigned this Jan 7, 2025
@Jo-Minseok Jo-Minseok changed the title Refactor/nestjs-directory ♻️ refactor: 디렉토리 구조 controller, service, repository, module 분리 Jan 7, 2025
CodeVac513
CodeVac513 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Collaborator

@CodeVac513 CodeVac513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고 많으셨습니다.

asn6878
asn6878 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@asn6878 asn6878 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인 완료했습니다~
고생하셨어요 👍

@Jo-Minseok Jo-Minseok merged commit 5c4dc05 into main Jan 7, 2025
1 check passed
@Jo-Minseok Jo-Minseok deleted the refactor/nestjs-directory branch January 7, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CodeVac513 CodeVac513 CodeVac513 approved these changes

@asn6878 asn6878 asn6878 approved these changes

Assignees

@Jo-Minseok Jo-Minseok

Labels

🔨 Refactor 리팩토링 (구조 변경)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Jo-Minseok @CodeVac513 @asn6878