forked from boostcampwm-2024/web20-camon
-
Notifications
You must be signed in to change notification settings - Fork 0
[Refactor] 코딩 컨벤션 재정의 및 적용 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- react/jtructed-context-values: useMemo 활용
3 tasks
g00hyun
approved these changes
Jan 13, 2025
seungheon123
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ 연관된 이슈
✨ 구현 기능 명세
🎁 PR Point
airbnb eslint(eslint-config-airbnb) 적용
airbnb eslint를 적용하기 위한 eslint 플러그인들을 설치했다. 타입스크립트를 사용하기 때문에 타입스크립트 관련 패키지도 함께 설치했다.
.eslintrc
airbnb의 eslint 설정을 현재 프로젝트에 맞도록 수정한 결과.
정리 문서: 🔗코드 품질 개선2-1: 코딩 컨벤션(eslint-config-airbnb 적용)
타입 선언 type alias 방식으로 통일
기존에 타입 선언 방식으로
interface와type alias가 혼용되던 것을 하나로 통일했다. 현재 프로젝트에서는 type alias가 적합하다고 생각하여 모두 type alias로 변경했다.정리 문서: 🔗코드 품질 개선2-2: 코딩 컨벤션(interface vs type alias)
😭 어려웠던 점
프로젝트를 다 개발한 뒤에 코딩 컨벤션을 다시 확인하고 eslint 패키지를 적용하려니 시간이 오래걸리고 어려웠다. 다음 프로젝트를 처음부터 할 일이 있다면 이번에 정리한 내용을 바탕으로 초기 설정을 잘해야겠다.