Skip to content

Conversation

@krokerdile
Copy link
Collaborator

πŸ”οΈ 이 PR을 톡해 ν•΄κ²°ν•˜λ €λŠ” λ¬Έμ œκ°€ λ¬΄μ—‡μΈκ°€μš”?

Vite ν™˜κ²½μ—μ„œ Web Worker 지원을 μœ„ν•œ 섀정이 λˆ„λ½λ˜μ–΄ μžˆμ—ˆμŠ΅λ‹ˆλ‹€. 이둜 인해 Web Workerλ₯Ό ν™œμš©ν•œ κΈ°λŠ₯ κ΅¬ν˜„μ— μ œμ•½μ΄ μžˆμ—ˆμŠ΅λ‹ˆλ‹€. λ˜ν•œ, λ‘€μ—… μ„€μ •μ˜ μ΅œμ ν™”κ°€ ν•„μš”ν•œ μƒν™©μ΄μ—ˆμŠ΅λ‹ˆλ‹€.

✨ 이 PRμ—μ„œ ν•΅μ‹¬μ μœΌλ‘œ λ³€κ²½λœ 사항은 λ¬΄μ—‡μΌκΉŒμš”?

  1. Vite ν™˜κ²½μ—μ„œ Web Worker ν™œμš©μ„ μœ„ν•œ TypeScript 섀정을 μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
    • vite-env.d.ts에 Web Worker νƒ€μž… μ •μ˜λ₯Ό μΆ”κ°€ν•˜μ—¬ νƒ€μž… μ•ˆμ •μ„± 확보
  2. vite.config νŒŒμΌμ— λ‘€μ—… μ˜΅μ…˜μ„ μΆ”κ°€ν•˜μ—¬ λΉŒλ“œ ν”„λ‘œμ„ΈμŠ€λ₯Ό κ°œμ„ ν–ˆμŠ΅λ‹ˆλ‹€.
    • λ²ˆλ“€ μ΅œμ ν™”λ₯Ό μœ„ν•œ λ‘€μ—… μ„€μ • ꡬ성
    • Worker κ΄€λ ¨ ν”ŒλŸ¬κ·ΈμΈ μ„€μ • μΆ”κ°€

πŸ”– 핡심 λ³€κ²½ 사항 외에 μΆ”κ°€μ μœΌλ‘œ λ³€κ²½λœ 뢀뢄이 μžˆλ‚˜μš”?

λΆˆν•„μš”ν•œ console 둜그λ₯Ό μ œκ±°ν•˜μ—¬ μ½”λ“œ 정리λ₯Ό μˆ˜ν–‰ν–ˆμŠ΅λ‹ˆλ‹€.

πŸ™ Reviewer 뢄듀이 이런 뢀뢄을 μ‹ κ²½μ¨μ„œ 봐 μ£Όμ‹œλ©΄ μ’‹κ² μ–΄μš”

  1. Web Worker 섀정이 ν”„λ‘œμ νŠΈμ˜ μš”κ΅¬μ‚¬ν•­μ— 맞게 κ΅¬μ„±λ˜μ—ˆλŠ”μ§€ κ²€ν†  λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.
  2. λ‘€μ—… 섀정이 졜적의 λΉŒλ“œ κ²°κ³Όλ₯Ό λ§Œλ“€μ–΄λ‚΄λŠ”μ§€ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.
  3. Worker κ΄€λ ¨ 섀정이 개발 및 ν”„λ‘œλ•μ…˜ ν™˜κ²½ λͺ¨λ‘μ—μ„œ μ •μƒμ μœΌλ‘œ λ™μž‘ν•˜λŠ”μ§€ 확인 λΆ€νƒλ“œλ¦½λ‹ˆλ‹€.

🩺 이 PRμ—μ„œ ν…ŒμŠ€νŠΈ ν˜Ήμ€ 검증이 ν•„μš”ν•œ 뢀뢄이 μžˆμ„κΉŒμš”?

  1. Web Workerλ₯Ό μ‚¬μš©ν•˜λŠ” κΈ°λŠ₯μ—μ„œ μ •μƒμ μœΌλ‘œ Workerκ°€ λ‘œλ“œλ˜λŠ”μ§€ 확인
  2. λΉŒλ“œ ν›„ λ²ˆλ“€ 크기와 λ‘œλ”© μ„±λŠ₯ 확인
  3. 개발 ν™˜κ²½κ³Ό ν”„λ‘œλ•μ…˜ ν™˜κ²½μ—μ„œμ˜ Worker λ™μž‘ ν…ŒμŠ€νŠΈ

@krokerdile krokerdile requested a review from a team December 5, 2024 08:04
Copy link
Collaborator

@codemario318 codemario318 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@codemario318 codemario318 merged commit 78a09eb into develop Dec 5, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants