Skip to content

Conversation

@felixwimpyw
Copy link

The class dynamoDBTemplateBuilder is still getting reference from field dynamoDBMapperName, while when we set attribute dynamoDBMapperRef in EnableDynamoDBRepositories, field of dynamoDBMapperName will always null. It makes the application failed to startup with Error java.lang.IllegalArgumentException: 'beanName' must not be empty

Fixing by registering using the correct attribute.

The class dynamoDBTemplateBuilder is still getting reference from field dynamoDBMapperName, while when we set attribute dynamoDBMapperRef in EnableDynamoDBRepositories, field of dynamoDBMapperName will always null. It makes the application failed to startup with Error java.lang.IllegalArgumentException: 'beanName' must not be empty

Fixing by registering using the correct attribute.
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #26 into develop will decrease coverage by 0.05%.
The diff coverage is 60.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop      #26      +/-   ##
=============================================
- Coverage      67.07%   67.01%   -0.06%     
  Complexity       664      664              
=============================================
  Files             84       84              
  Lines           2293     2295       +2     
  Branches         403      404       +1     
=============================================
  Hits            1538     1538              
- Misses           571      572       +1     
- Partials         184      185       +1     
Impacted Files Coverage Δ Complexity Δ
...tory/config/DynamoDBRepositoryConfigExtension.java 66.66% <60.00%> (-1.30%) 14.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d16c1b...4333726. Read the comment docs.

@boostchicken boostchicken merged commit a3e6ba0 into boostchicken:develop May 24, 2020
@boostchicken boostchicken linked an issue May 25, 2020 that may be closed by this pull request
@boostchicken boostchicken self-requested a review May 25, 2020 04:06
@boostchicken boostchicken self-assigned this May 25, 2020
@boostchicken boostchicken added the bug Something isn't working label May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to register dynamoDBMapperRef

3 participants