Remove some includes, fix some comments and docs #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of commit 4dac507 (Remove code to use standard library versions of algorithms), most of the files in cxx11 were including
<algorithm>unnecessarily.I suggest removing those includes where they are not used, and also removing comments which misleadingly said "We will use the standard one if it is available, otherwise we have our own implementation."
Also, the file copy_if.hpp wasn't including
<utility>where pair and make_pair can be found, and partition_point was missing an#include <iterator>.A second commit removes similar unused includes in cxx14/is_permutation.hpp and cxx14/mismatch.hpp, and adds a missing
#include <iterator>to cxx14/equal.hpp.A third commit removes incorrect statements from the docs.