Remove std::*nary_function #18
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to be fixed in develop. I think this PR can be closed. |
|
I'll merge to master after the beta. |
|
When you do, please, have a look at #34, which may make it easier for you. Or you can just close that PR if you don't need it. |
|
This is all done in develop. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You asked me to remind you about PR #17 / commit 3aef0ab so you could merge to master.
Also, in C++17, std::unary_function and std::binary_function will be removed from the standard, so we should also remove their uses.
I brought this up on the mailing list: What to do about std::binary_function and std::unary_function?
There was not a lot of response, but the slight preponderance of opinion seemed to be to just remove the inheritance: everything should keep working, but maybe provide a typedef for result_type for use with boost::bind.
I did that. I didn't add the typedef for the structs in
detailsince they are "internal."