Fix uniform real distribution #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis-CI tests failed only because of |
| // initialize the range_test_engine | ||
| range_test_engine<boost::compute::uint_> engine(queue); | ||
|
|
||
| // setup the uniform distribution to produce floats between 1 and 100 |
There was a problem hiding this comment.
Shouldn't this be between 0.9 and 1.0?
There was a problem hiding this comment.
You're right! I'll fix this in a minute.
Now generated floating-point values are uniformly distributed on the interval [a, b). Before this commit it was possible to produce values equal to b.
New test checks if values generated by uniform real distribution are in the [a,b) interval.
Making sure that the left endpoint (a) of the range in uniform real distribution is less than the right endpoint (b).
jszuppe
force-pushed
the
pr_fix_uni_real_dist
branch
from
5a987fe to
8aea290
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #587.
Now generated floating-point values are uniformly distributed on the interval
[a, b)and no value is greater or equal tob.I also added test that checks if results are in fact in
[a,b)range (by usingrange_test_engineclass that generates max random value or zeroes).