Fix find_end algorithm #597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to use the same queue in the whole test.
There was an uninitialized memory at the end of matching_indices vector and it was read by detail::find_end_helper(...) function resulting in wrong index returned by this function.
jszuppe
force-pushed
the
pr_fix_find_end
branch
from
701d607 to
940f379
Compare
|
Thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've found out what's wrong in the
find_endalgorithm. Using uninitialized memory (from the end ofmatching_indices) was causing undefined behaviour. It was uninitialized becausesearch_kerneldoes not initialize the last<pattern_size> - 1elements ofmatching_indicesas the pattern can not start there. Now it's fixed.