Skip to content

fix untrusted_checkout_exec line numbers #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix untrusted_checkout_exec line numbers #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opa/rego/rules/untrusted_checkout_exec.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ build_commands[cmd] = {

results contains poutine.finding(rule, pkg_purl, {
"path": workflow_path,
"line": step.line,
"line": step.lines.run,
"details": sprintf("Detected usage of `%s`", [cmd]),
}) if {
[pkg_purl, workflow_path, step] := _steps_after_untrusted_checkout[_]
Expand All @@ -49,7 +49,7 @@ results contains poutine.finding(rule, pkg_purl, {

results contains poutine.finding(rule, pkg_purl, {
"path": workflow_path,
"line": step.line,
"line": step.lines.uses,
"details": sprintf("Detected usage the GitHub Action `%s`", [step.action]),
}) if {
[pkg_purl, workflow_path, step] := _steps_after_untrusted_checkout[_]
Expand Down
6 changes: 3 additions & 3 deletions scanner/inventory_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func TestFindings(t *testing.T) {
Purl: purl,
Meta: opa.FindingMeta{
Path: ".github/workflows/valid.yml",
Line: 29,
Line: 30,
Details: "Detected usage of `npm`",
},
},
Expand All @@ -154,7 +154,7 @@ func TestFindings(t *testing.T) {
Purl: purl,
Meta: opa.FindingMeta{
Path: ".github/workflows/valid.yml",
Line: 55,
Line: 56,
Details: "Detected usage the GitHub Action `bridgecrewio/checkov-action`",
},
},
Expand All @@ -163,7 +163,7 @@ func TestFindings(t *testing.T) {
Purl: purl,
Meta: opa.FindingMeta{
Path: ".github/workflows/valid.yml",
Line: 59,
Line: 60,
Details: "Detected usage of `pre-commit`",
},
},
Expand Down