Skip to content

Conversation

cgwalters
Copy link
Collaborator

This avoids warnings from bootctl install for good reasons. Visible from bootc install using systemd-boot.

This avoids warnings from `bootctl install` for good reasons.
Visible from `bootc install` using systemd-boot.

Signed-off-by: Colin Walters <walters@verbum.org>
@bootc-bot bootc-bot bot requested a review from henrywang October 19, 2025 18:13
@cgwalters cgwalters enabled auto-merge (rebase) October 19, 2025 18:14
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a significant improvement by mounting the EFI System Partition (ESP) with more restrictive permissions (fmask=0177, dmask=0077) and security flags (noexec, nosuid). This change effectively hardens the system by limiting access to the ESP, which helps prevent unauthorized modifications and resolves warnings from bootctl. The implementation is well-executed through refactoring. A new mount_esp helper function neatly encapsulates the ESP mounting logic, which is then used consistently across the codebase, improving maintainability. Furthermore, the underlying TempMount::mount_dev function has been enhanced to be more generic and now uses a direct rustix syscall for mounting instead of shelling out to the mount command, which is a great improvement for robustness and performance. Overall, the changes are clean, well-motivated, and represent a solid step forward for the project's security and code quality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant