composefs-backend: Handle rollback for systemd-boot #1698
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds rollback support for systemd-boot in the composefs backend, which was a missing piece. The changes involve refactoring the rollback logic to be more generic and handle both Grub and systemd-boot. The function renames and improved use of cap-std are good improvements.
My review focuses on a compilation error, a potential panic, and some opportunities for refactoring to improve code clarity and robustness. Overall, this is a good step forward, and with these changes, it will be even better.
Johan-Liebert1
force-pushed
the
sdboot-rollback
branch
2 times, most recently
from
c55ad09 to
7f3c5c5
Compare
|
RPM builds failing with Okay, we already have an issue for this #1692 |
This piece was leftover when implementing systemd-boot support for composefs backend Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com> Some refactor Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
Johan-Liebert1
force-pushed
the
sdboot-rollback
branch
from
7f3c5c5 to
36add80
Compare
Suggested by Gemini Accept a param `boot_dir`, fd to the boot directory, in function `rollback_grub_uki_entries`. Removes hardcoded paths and makes the code a tiny bit cleaner. Signed-off-by: Pragyan Poudyal <pragyanpoudyal41999@gmail.com>
cgwalters
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This piece was leftover when implementing systemd-boot support for composefs backend