Skip to content

Conversation

@jeckersb
Copy link
Collaborator

Signed-off-by: John Eckersberg jeckersb@redhat.com

Signed-off-by: John Eckersberg <jeckersb@redhat.com>
@bootc-bot bootc-bot bot requested a review from gursewak1997 October 28, 2025 19:27
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Packit configuration to include fedora-43 as a target for both Copr builds and tests. The changes are consistent with the existing structure of the configuration file. I have one suggestion to improve the clarity of a comment.

Comment on lines +35 to +36
# Primary targets are c9s, c10s and supported fedora right now,
# which build for all architectures
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The phrase "which build for all architectures" could be slightly misleading, as other targets in this job (like fedora-rawhide) build for additional architectures (e.g., ppc64le). For better clarity and to avoid confusion, you could refine the comment to reflect that these builds cover the primary set of architectures.

      # Primary targets are c9s, c10s and supported fedora right now,
      # which build for the primary architectures

@jeckersb jeckersb enabled auto-merge (rebase) October 28, 2025 20:37
@jeckersb
Copy link
Collaborator Author

We'll have to update CI / test-integration (fedora-43) to be a Required job as well, but IIRC that's a clicky click github UI thing that I don't appear to have access to modify.

@jeckersb jeckersb merged commit edbfb11 into bootc-dev:main Oct 28, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants