ci: Just use one job for build + test #1716
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the future, we may want to "shard" tests across multiple runners, but as is right now it's basically just adding overhead to copy the disk image as an artifact across the job. While we're here, clean things up further to match the general principle that GHA flows should mostly just be running `just`. The logic from build.sh to map from strings -> containers though moves into the GHA for now. Signed-off-by: Colin Walters <walters@verbum.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the CI by combining build and test jobs, which is a positive change for efficiency. However, the removal of tests/build.sh introduces a breaking change for local development workflows by breaking several just commands (build-disk, test-tmt, test-tmt-one) that depend on this script. My review provides a suggestion to either restore this functionality within the Justfile or remove the broken commands to maintain a usable local development environment.
Collaborator
Author
|
@gursewak1997 this one should be a straightforward review when you have a sec |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the future, we may want to "shard" tests across multiple runners, but as is right now it's basically just adding overhead to copy the disk image as an artifact across the job.
While we're here, clean things up further to match the general principle that GHA flows should mostly just be running
just. The logic from build.sh to map from strings -> containers though moves into the GHA for now.