Skip to content

Conversation

@qcam
Copy link
Contributor

@qcam qcam commented Jul 18, 2014

Hi, thanks for this awesome gem. I have added the generate_help I18n translation support when user pass in help: true

@potenza
Copy link
Member

potenza commented Jul 18, 2014

Hi @huynhquancam, thanks for the PR! I think this is a nice addition. I have one minor nitpick. Can you change helps to help? The singular form feels better to me.

@qcam
Copy link
Contributor Author

qcam commented Jul 19, 2014

Hi @potenza, thanks. 👍 I have updated the method and test. Please take a look.

@potenza
Copy link
Member

potenza commented Jul 19, 2014

@huynhquancam thank you! I have one more question. Rather than having to pass help: true, do you think it would be better if we detected the help translation automatically (if no help string was passed in)?

@qcam
Copy link
Contributor Author

qcam commented Jul 19, 2014

@potenza yup, I think that would be great. Do you think it would be even better to ignore the help translation in case of help: false as some forms need to have help text, some forms don't.

@potenza
Copy link
Member

potenza commented Jul 21, 2014

looks good 👍

potenza added a commit that referenced this pull request Jul 21, 2014
#generate_help for I18n convention support
@potenza potenza merged commit 144de80 into bootstrap-ruby:master Jul 21, 2014
potenza added a commit that referenced this pull request Jul 21, 2014
@carloslopes
Copy link
Member

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants