Allow to pass any attributes to wrapper (not just class)

[atipugin]

No description provided.

[carloslopes]

Hey @atipugin, thanks for your PR!

For me it's fine, let's just ask @datWav what he think about it, because the wrapper_class option was added by him.

@datWav what do you think? Do we keep both wrapper_* options or is it fine to use only the wrapper_options?

[potenza]

@atipugin thanks! I like this, the only thing I'm concerned about is that it makes it a little more verbose to add a wrapper class. I don't use this option all that much so it's not really a big deal for me.

[carloslopes]

@potenza yeah, we can keep both options too (wrapper_class that is most commonly used and wrapper_options that is more complete)

[datWav]

@potenza, @carloslopes I think both options are good. It is simpler to write only wrapper_class if you want to add just the class.
The wrapper_options possibility is the same as form_group label: {text: 'label'}.

What do you think if we use only wrapper: {} and parse all options to the wrapper element?

[carloslopes]

@datWav I agree.

So, we will have both options, wrapper and wrapper_class.

Can you work on this @atipugin?

[atipugin]

Sure but no sooner than next week ;)

[carloslopes]

Np!
On Sep 6, 2014 2:06 PM, "Alexander Tipugin" notifications@github.com
wrote:

Sure but no sooner than next week ;)

—
Reply to this email directly or view it on GitHub
#136 (comment)
.

[atipugin]

Done.

[atipugin]

Rebased my PR on top of current master, so we can merge it now :)

[potenza]

👍

[pelted]

What about turning of the wrapper entirely. I came across issue #62 with regard to have more than one text field in a row when using horizontal layout. The problem with the provided solution is that the fields still get wrapped thus making the solution to that issue useless without being able to turn off the wrapper.