Allow users to display validation errors in labels #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you provide a screenshot with errors in label? Because i don't understand how it would look like :)) |
|
Certainly! Here's an example: |
|
Looks great, can't wait to see it in master 👍 |
|
@timcheadle thanks for the PR! @carloslopes thoughts? |
|
Cool, for me it's fine. Thanks for the PR @timcheadle! |
carloslopes
added a commit
that referenced
this pull request
Sep 22, 2014
Allow users to display validation errors in labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was building forms in which displaying the validation errors in the label was much more efficient than showing them as help text. This
:label_errorsoption makes that easy, and allows the user to turn on both if they want.