Skip to content

Conversation

@atipugin
Copy link
Contributor

Sometimes hide_label: true is not enough, as it still renders useless markup.

@carloslopes
Copy link
Member

iirc the problem with this is that it breaks with horizontal forms. Can you check if this doesn't brake the page layout when using horizontal form?

@atipugin
Copy link
Contributor Author

My bad, never used horizontal layout with this :) Will check it out.

@MichaelSp
Copy link

Great. I've been missing this feature since 2 month!
Please merge this....

@atipugin
Copy link
Contributor Author

atipugin commented Oct 7, 2014

I hope i'll fix issue w/ horizontal layout this week. After that we can merge it.

@atipugin
Copy link
Contributor Author

atipugin commented Oct 9, 2014

I've checked it out and i don't really see any issues with it. If we use skip_label, column with input will have offset class. Here is an example:

Without skip_label:
screenshot 2014-10-09 10 40 51

And with it:
screenshot 2014-10-09 10 45 19

For me it's just fine behavior. Or may be i'm missing something?:)

@carloslopes
Copy link
Member

d'oh! I forgot that @datWav already fixed this issue with the offset.

Sorry for the delay, I was on vacation 😎

Thanks for the PR @atipugin!

carloslopes added a commit that referenced this pull request Oct 20, 2014
Allow to skip label rendering
@carloslopes carloslopes merged commit 6b0ca0b into bootstrap-ruby:master Oct 20, 2014
carloslopes added a commit that referenced this pull request Oct 20, 2014
@atipugin
Copy link
Contributor Author

Great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants