Support form objects that lack model names #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful in using Bootstrap Forms with third party libraries such as Ransack, whose queries and values do not always conform fully to the Active Model API. A class's name, while model_name is preferred, is still a good fallback.
|
Looks good to me! Thanks for the PR and the test. 🙌 Can you add a CHANGELOG entry so that I can merge this? |
[skip ci]
|
@mattbrictson Thank you! I just pushed an update to the changelog. |
|
Thanks for your contribution! 🙇 |
|
Great, thank you! Do you have a scheduled time for the next release so I can check back in? |
|
For non-critical bug fixes, I usually push a release every 6 weeks. So the next release would be early November. In the meantime you can update your Gemfile to use the master branch: gem "bootstrap_form", :github => "bootstrap-ruby/rails-bootstrap-forms" |
|
FYI, I just released 2.5.2 with this included. 🚢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is useful in using Bootstrap Forms with third party libraries such as Ransack, whose queries and values do not always conform fully to the Active Model API.
A class's name, while model_name is preferred, is still a good fallback.