Skip to content

Fixed: Append and Prepend #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fixed: Append and Prepend #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/bootstrap_form/helpers/bootstrap.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ def static_class

def attach_input(options, key)
tags = [*options[key]].map do |item|
tag.div(input_group_content(item), class: "input-group-#{key}")
input_group_content(item)
end
ActiveSupport::SafeBuffer.new(tags.join)
end
Expand Down
24 changes: 6 additions & 18 deletions test/bootstrap_form_group_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@ class BootstrapFormGroupTest < ActionView::TestCase
<div class="form-group">
<label class="required" for="user_email">Email</label>
<div class="input-group">
<div class="input-group-prepend">
<span class="input-group-text">@</span>
</div>
<span class="input-group-text">@</span>
<input class="form-control" id="user_email" name="user[email]" type="text" value="steve@example.com" />
</div>
</div>
Expand All @@ -137,9 +135,7 @@ class BootstrapFormGroupTest < ActionView::TestCase
<label class="required" for="user_email">Email</label>
<div class="input-group">
<input class="form-control" id="user_email" name="user[email]" type="text" value="steve@example.com" />
<div class="input-group-append">
<span class="input-group-text">.00</span>
</div>
<span class="input-group-text">.00</span>
</div>
</div>
HTML
Expand Down Expand Up @@ -168,13 +164,9 @@ class BootstrapFormGroupTest < ActionView::TestCase
<div class="form-group">
<label class="required" for="user_email">Email</label>
<div class="input-group">
<div class="input-group-prepend">
<span class="input-group-text">$</div>
</div>
<span class="input-group-text">$</div>
<input class="form-control" id="user_email" name="user[email]" type="text" value="steve@example.com" />
<div class="input-group-append">
<span class="input-group-text">.00</span>
</div>
<span class="input-group-text">.00</span>
</div>
</div>
HTML
Expand All @@ -191,13 +183,9 @@ class BootstrapFormGroupTest < ActionView::TestCase
<div class="form-group">
<label class="required" for="user_email">Email</label>
<div class="input-group">
<div class="input-group-prepend">
<span class="input-group-text">$</div>
</div>
<span class="input-group-text">$</div>
<input class="form-control is-invalid" id="user_email" name="user[email]" type="text" />
<div class="input-group-append">
<span class="input-group-text">.00</span>
</div>
<span class="input-group-text">.00</span>
<div class="invalid-feedback">can't be blank, is too short (minimum is 5 characters)</span>
</div>
</div>
Expand Down