Add rails 7.2 to matrix #741
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcreid
force-pushed
the
add-rails-7.2-to-matrix
branch
from
f823e30 to
ee870aa
Compare
The capybara diff stuff changed a lot with the version upgrade.
I assume this is because I upgraded gems and packages, and something is capturing screenshots slightly differently.
lcreid
force-pushed
the
add-rails-7.2-to-matrix
branch
from
c97b4be to
7bd3e80
Compare
I can't wait until Rails ships with Rubocop.
Please review the changes in the files in this commit carefully, as they were automatically generated during CI. Run `git pull` to bring the changes into your local branch. Then, if you do not want the changes, run `git revert HEAD`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also an update to two image files. And another directory added to
.gitignorebecause Git Kraken creates something that shows up, at least in the Docker case.Actually, getting everything up-to-date appears to render the screenshots (or maybe capture them) differently, so all the screenshots have changed.
The usual screw-arounds with the schema versioning -- we can't use the schema versioning yet. Maybe with 7.0?
As the newer versions of Rails drop Ruby versions, we have to pay more attention to the version for the demo app.