inline: true generates the same CSS for the collection label as lay…
#778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
inline: truegenerate the same CSS for the collection label aslayout: :inline. This applies tocollection_checkboxesandcollection_radio_buttons. See the changes in the test cases of this PR for details, and compare to thelayout: :inlinetest cases (example) intest/bootstrap_form_test.rb.While this is a breaking change in some senses (it changes the generated marktup), I would classify it more as a bug fix. The previous mark-up would not have give the expected layout. So either the programmer worked around it some other way, or they didn't want
inline: truein the first place, and can simply removeinline: true.Closes: #777 .